ash/shelf/overflow_bubble_view.cc - Issue 1914093002: Refactors DockedWindowLayoutManager in terms of ash/wm/common

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/overflow_bubble_view.cc

Issue 1914093002: Refactors DockedWindowLayoutManager in terms of ash/wm/common (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nuke_aura_window

Patch Set: comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shelf/overflow_bubble_view.cc

diff --git a/ash/shelf/overflow_bubble_view.cc b/ash/shelf/overflow_bubble_view.cc

index 80ead85b2794565644164a4973f04eeb3fd499f9..23424ed5005d8d3a3a912ddd451f28afe38f4e3d 100644

--- a/ash/shelf/overflow_bubble_view.cc

+++ b/ash/shelf/overflow_bubble_view.cc

@@ -12,6 +12,7 @@

#include "ash/shelf/shelf_view.h"

#include "ash/shell.h"

#include "ash/shell_window_ids.h"

+#include "ash/wm/common/shelf/wm_shelf_constants.h"

#include "ui/events/event.h"

#include "ui/gfx/geometry/insets.h"

#include "ui/gfx/screen.h"

@@ -43,7 +44,7 @@ void OverflowBubbleView::InitOverflowBubble(views::View* anchor,

SetAnchorView(anchor);

set_arrow(GetBubbleArrow());

set_background(NULL);

- set_color(SkColorSetARGB(kShelfBackgroundAlpha, 0, 0, 0));

+ set_color(SkColorSetARGB(wm::kShelfBackgroundAlpha, 0, 0, 0));

set_margins(gfx::Insets(kPadding, kPadding, kPadding, kPadding));

// Overflow bubble should not get focus. If it get focus when it is shown,

// active state item is changed to running state.

« no previous file with comments | « ash/shelf/app_list_button.cc ('k') | ash/shelf/overflow_button.cc » ('j') | no next file with comments »