Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1913943003: Remove dependencies on chrome\installer from the ChromeCrashReporterClient class on Windows. (Closed)

Created:
4 years, 8 months ago by ananta
Modified:
4 years, 7 months ago
CC:
chromium-reviews, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependencies on chrome\installer from the ChromeCrashReporterClient class on Windows. This is step 2 of the work underway to move the crash pad registration from chrome.exe to chrome_elf. Most of the changes in this patch are addition of helper functions to the install_static_util library to retrieve the channel name, user data directory, chrome version information etc. I added TODOs to these functions with comments that we need to consolidate these with similar functions in Chrome\installer. As install_static is pulled in by chrome_elf, we cannot depend on functionality in base which brings in dependencies on user32. This includes utf8 to utf16 conversion, pattern matching functions, etc. I added implementations of the functions we need to install_util.cc. Once we test this out in the field and things work well, we will move the crash pad registration into chrome_elf BUG=604923 Committed: https://crrev.com/8d6f29a4043e293c44371496e9d729e2dfacd04e Cr-Commit-Position: refs/heads/master@{#392834}

Patch Set 1 #

Patch Set 2 : Fix indentation #

Patch Set 3 : Update DEPS and fix build error #

Patch Set 4 : Update comment #

Patch Set 5 : Update dependencies for tests for build error #

Patch Set 6 : Fix indentation #

Patch Set 7 : Update dependencies for unit_tests and interactive_ui_tests #

Patch Set 8 : Remove tabs #

Patch Set 9 : Update dependencies for chrome/installer #

Total comments: 38

Patch Set 10 : Address review comments #

Total comments: 8

Patch Set 11 : Fix official build check #

Total comments: 4

Patch Set 12 : Address review comments #

Patch Set 13 : Fix bot redness with nacl #

Patch Set 14 : Rebased to tip #

Patch Set 15 : Fix nacl64 build #

Patch Set 16 : Fix winclang builder #

Patch Set 17 : Fix win rel bot redness by removing some dependencies on base #

Patch Set 18 : Fix presubmit and revert some needless changes #

Total comments: 22

Patch Set 19 : Rebased to tip and address scottmg comments #

Patch Set 20 : Rebased chrome_crash_reporter_client_win.cc to tip #

Patch Set 21 : Fix chrome_elf link failure by removing dependency on base pattern.h #

Patch Set 22 : Fix MatchPattern #

Total comments: 8

Patch Set 23 : Added a unittest for the install_static MatchPattern function. #

Total comments: 6

Patch Set 24 : Fix compile failure on win_clang and fix the chrome_elf_unittests on 64 bit. We need to add version… #

Total comments: 7

Patch Set 25 : Address review comments and add tests #

Patch Set 26 : Update comment #

Total comments: 69

Patch Set 27 : Address grt review comments #

Patch Set 28 : Address remaining comments from grt and fix build errors #

Patch Set 29 : Declare common constants in install_util.h and remove dups from chrome_elf_util_unittest.cc #

Total comments: 4

Patch Set 30 : Address grt comments #

Patch Set 31 : Fix build error #

Total comments: 28

Patch Set 32 : Address grt comments and add unittest for install_static::GetChromeChannelName #

Patch Set 33 : Fix build error #

Patch Set 34 : Fix build error and test failures #

Total comments: 9

Patch Set 35 : Address grt comments #

Patch Set 36 : Update ChromeElfUtilTest.InstallStaticGetChannelNameTest for changed expectations for channel name #

Total comments: 15

Patch Set 37 : Add test cases for install_static::GetChromeChannelName with no modifiers. #

Patch Set 38 : Return the channel name with the modifier as -m if |add_modifier| is true in all cases. #

Patch Set 39 : Fixed compile err #

Total comments: 2

Patch Set 40 : Remove outdated comment #

Patch Set 41 : Update DEPS #

Patch Set 42 : Attempt to fix checkdeps failures #

Patch Set 43 : Fix DEPs includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1057 lines, -216 lines) Patch
M chrome/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 7 chunks +49 lines, -103 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +11 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_paths_internal.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/chrome_paths_win.cc View 1 chunk +0 lines, -14 lines 0 comments Download
A chrome/install_static/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 1 chunk +10 lines, -0 lines 0 comments Download
A + chrome/install_static/OWNERS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +1 line, -1 line 0 comments Download
M chrome/install_static/install_util.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 2 chunks +124 lines, -8 lines 0 comments Download
M chrome/install_static/install_util.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 10 chunks +562 lines, -40 lines 0 comments Download
M chrome/installer/util/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/util/DEPS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +4 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +3 lines, -0 lines 0 comments Download
M chrome_elf/blacklist/blacklist.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/blacklist/test/blacklist_test_main_dll.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/breakpad.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 3 chunks +12 lines, -8 lines 0 comments Download
M chrome_elf/chrome_elf_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/chrome_elf_util_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 6 chunks +262 lines, -30 lines 0 comments Download
M chrome_elf/elf_imports_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +5 lines, -1 line 0 comments Download
M components/nacl/broker/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 77 (22 generated)
ananta
4 years, 8 months ago (2016-04-25 23:58:04 UTC) #2
ananta
+robertshield
4 years, 8 months ago (2016-04-26 00:20:38 UTC) #4
scottmg
Looks like the GN build is pulling in user32. Pretty nervous about this given our ...
4 years, 7 months ago (2016-04-26 18:38:02 UTC) #5
scottmg
https://codereview.chromium.org/1913943003/diff/160001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc (right): https://codereview.chromium.org/1913943003/diff/160001/chrome/install_static/install_util.cc#newcode416 chrome/install_static/install_util.cc:416: return false; If this returns false, then special_build and ...
4 years, 7 months ago (2016-04-26 18:51:30 UTC) #6
scottmg
Should have grt look at the installer/version stuff once we think we're ready, too. :)
4 years, 7 months ago (2016-04-26 18:52:21 UTC) #7
robertshield
very quick drive by, elf code lg, let me know if you'd like a full ...
4 years, 7 months ago (2016-04-26 18:56:33 UTC) #8
ananta
https://codereview.chromium.org/1913943003/diff/160001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc (right): https://codereview.chromium.org/1913943003/diff/160001/chrome/install_static/install_util.cc#newcode173 chrome/install_static/install_util.cc:173: base::string16* value_str) { On 2016/04/26 18:56:33, robertshield wrote: > ...
4 years, 7 months ago (2016-04-26 20:23:16 UTC) #9
scottmg
OK, lgtm-enough to get grt to scrutinize and be scared now. :) https://codereview.chromium.org/1913943003/diff/180001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc ...
4 years, 7 months ago (2016-04-26 20:44:47 UTC) #10
ananta
https://codereview.chromium.org/1913943003/diff/180001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc (right): https://codereview.chromium.org/1913943003/diff/180001/chrome/install_static/install_util.cc#newcode358 chrome/install_static/install_util.cc:358: size)) { On 2016/04/26 20:44:47, scottmg wrote: > Confirm ...
4 years, 7 months ago (2016-04-26 21:33:09 UTC) #11
ananta
4 years, 7 months ago (2016-04-27 22:50:57 UTC) #13
scottmg
https://codereview.chromium.org/1913943003/diff/340001/chrome/app/chrome_crash_reporter_client_win.cc File chrome/app/chrome_crash_reporter_client_win.cc (right): https://codereview.chromium.org/1913943003/diff/340001/chrome/app/chrome_crash_reporter_client_win.cc#newcode106 chrome/app/chrome_crash_reporter_client_win.cc:106: std::string version_string = install_static::GetGoogleUpdateVersion(); #include <string> https://codereview.chromium.org/1913943003/diff/340001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc ...
4 years, 7 months ago (2016-04-27 23:29:25 UTC) #14
ananta
https://codereview.chromium.org/1913943003/diff/340001/chrome/app/chrome_crash_reporter_client_win.cc File chrome/app/chrome_crash_reporter_client_win.cc (right): https://codereview.chromium.org/1913943003/diff/340001/chrome/app/chrome_crash_reporter_client_win.cc#newcode106 chrome/app/chrome_crash_reporter_client_win.cc:106: std::string version_string = install_static::GetGoogleUpdateVersion(); On 2016/04/27 23:29:24, scottmg wrote: ...
4 years, 7 months ago (2016-04-28 00:04:25 UTC) #15
ananta
+sky for chrome owners
4 years, 7 months ago (2016-04-28 00:06:28 UTC) #17
ananta
+grt for installer changes. Please take a look at the overall change and specifically at ...
4 years, 7 months ago (2016-04-28 00:19:33 UTC) #19
sky
LGTM
4 years, 7 months ago (2016-04-28 03:39:03 UTC) #20
ananta
+dschuff for components/nacl
4 years, 7 months ago (2016-04-28 21:25:59 UTC) #24
scottmg
https://codereview.chromium.org/1913943003/diff/440001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc (right): https://codereview.chromium.org/1913943003/diff/440001/chrome/install_static/install_util.cc#newcode281 chrome/install_static/install_util.cc:281: Trace(L"%hs( %ls directory exists)\n", __FUNCTION__, full_path_str); extra space here ...
4 years, 7 months ago (2016-04-28 21:34:01 UTC) #25
ananta
https://codereview.chromium.org/1913943003/diff/440001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc (right): https://codereview.chromium.org/1913943003/diff/440001/chrome/install_static/install_util.cc#newcode281 chrome/install_static/install_util.cc:281: Trace(L"%hs( %ls directory exists)\n", __FUNCTION__, full_path_str); On 2016/04/28 21:34:00, ...
4 years, 7 months ago (2016-04-28 22:54:40 UTC) #26
scottmg
lg https://codereview.chromium.org/1913943003/diff/460001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc (right): https://codereview.chromium.org/1913943003/diff/460001/chrome/install_static/install_util.cc#newcode354 chrome/install_static/install_util.cc:354: // which matches 0 or more instances of ...
4 years, 7 months ago (2016-04-28 23:16:42 UTC) #27
ananta
https://codereview.chromium.org/1913943003/diff/460001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc (right): https://codereview.chromium.org/1913943003/diff/460001/chrome/install_static/install_util.cc#newcode354 chrome/install_static/install_util.cc:354: // which matches 0 or more instances of any ...
4 years, 7 months ago (2016-04-29 02:28:06 UTC) #28
Derek Schuff
On 2016/04/29 02:28:06, ananta wrote: > https://codereview.chromium.org/1913943003/diff/460001/chrome/install_static/install_util.cc > File chrome/install_static/install_util.cc (right): > > https://codereview.chromium.org/1913943003/diff/460001/chrome/install_static/install_util.cc#newcode354 > ...
4 years, 7 months ago (2016-04-29 07:08:28 UTC) #29
grt (UTC plus 2)
whew! partial review. more to come. https://codereview.chromium.org/1913943003/diff/520001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc (right): https://codereview.chromium.org/1913943003/diff/520001/chrome/install_static/install_util.cc#newcode1 chrome/install_static/install_util.cc:1: // Copyright 2014 ...
4 years, 7 months ago (2016-04-29 20:50:57 UTC) #30
ananta
https://codereview.chromium.org/1913943003/diff/520001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc (right): https://codereview.chromium.org/1913943003/diff/520001/chrome/install_static/install_util.cc#newcode1 chrome/install_static/install_util.cc:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
4 years, 7 months ago (2016-04-29 22:49:25 UTC) #31
grt (UTC plus 2)
more comments from another partial pass. https://codereview.chromium.org/1913943003/diff/520001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc (right): https://codereview.chromium.org/1913943003/diff/520001/chrome/install_static/install_util.cc#newcode167 chrome/install_static/install_util.cc:167: LanguageAndCodePage* translation_info = ...
4 years, 7 months ago (2016-05-02 22:22:06 UTC) #32
ananta
On 2016/05/02 22:22:06, grt wrote: > more comments from another partial pass. > > https://codereview.chromium.org/1913943003/diff/520001/chrome/install_static/install_util.cc ...
4 years, 7 months ago (2016-05-02 22:39:52 UTC) #33
ananta
https://codereview.chromium.org/1913943003/diff/520001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc (right): https://codereview.chromium.org/1913943003/diff/520001/chrome/install_static/install_util.cc#newcode192 chrome/install_static/install_util.cc:192: return false; On 2016/05/02 22:22:06, grt wrote: > On ...
4 years, 7 months ago (2016-05-02 22:43:28 UTC) #34
grt (UTC plus 2)
https://codereview.chromium.org/1913943003/diff/620001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc (right): https://codereview.chromium.org/1913943003/diff/620001/chrome/install_static/install_util.cc#newcode324 chrome/install_static/install_util.cc:324: DWORD file_attributes = GetFileAttributes(full_path_str); nit: ::GetFileAttributes as above https://codereview.chromium.org/1913943003/diff/620001/chrome/install_static/install_util.cc#newcode637 ...
4 years, 7 months ago (2016-05-03 10:47:55 UTC) #35
grt (UTC plus 2)
https://codereview.chromium.org/1913943003/diff/620001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc (right): https://codereview.chromium.org/1913943003/diff/620001/chrome/install_static/install_util.cc#newcode637 chrome/install_static/install_util.cc:637: void GetChromeChannelName(bool is_per_user_install, On 2016/05/03 10:47:55, grt wrote: > ...
4 years, 7 months ago (2016-05-03 15:54:55 UTC) #36
ananta
https://codereview.chromium.org/1913943003/diff/620001/chrome/install_static/install_util.cc File chrome/install_static/install_util.cc (right): https://codereview.chromium.org/1913943003/diff/620001/chrome/install_static/install_util.cc#newcode324 chrome/install_static/install_util.cc:324: DWORD file_attributes = GetFileAttributes(full_path_str); On 2016/05/03 10:47:55, grt wrote: ...
4 years, 7 months ago (2016-05-03 21:40:57 UTC) #37
ananta
PTAL when you get a chance. Would like to land this to get some data ...
4 years, 7 months ago (2016-05-04 23:01:35 UTC) #39
grt (UTC plus 2)
Final comments (I swear). Thanks for being patient. I am apprehensive about landing such a ...
4 years, 7 months ago (2016-05-05 20:36:52 UTC) #40
ananta
There is very little test coverage for crashpad. I added a todo for myself and ...
4 years, 7 months ago (2016-05-05 20:57:35 UTC) #41
grt (UTC plus 2)
https://codereview.chromium.org/1913943003/diff/740001/chrome_elf/chrome_elf_util_unittest.cc File chrome_elf/chrome_elf_util_unittest.cc (right): https://codereview.chromium.org/1913943003/diff/740001/chrome_elf/chrome_elf_util_unittest.cc#newcode189 chrome_elf/chrome_elf_util_unittest.cc:189: install_static::GetChromeChannelName(!system_level_, true, &channel); please add test coverage for the ...
4 years, 7 months ago (2016-05-06 15:05:01 UTC) #42
ananta
https://codereview.chromium.org/1913943003/diff/740001/chrome_elf/chrome_elf_util_unittest.cc File chrome_elf/chrome_elf_util_unittest.cc (right): https://codereview.chromium.org/1913943003/diff/740001/chrome_elf/chrome_elf_util_unittest.cc#newcode189 chrome_elf/chrome_elf_util_unittest.cc:189: install_static::GetChromeChannelName(!system_level_, true, &channel); On 2016/05/06 15:05:01, grt (slow) wrote: ...
4 years, 7 months ago (2016-05-06 19:36:03 UTC) #43
ananta
https://codereview.chromium.org/1913943003/diff/740001/chrome_elf/chrome_elf_util_unittest.cc File chrome_elf/chrome_elf_util_unittest.cc (right): https://codereview.chromium.org/1913943003/diff/740001/chrome_elf/chrome_elf_util_unittest.cc#newcode319 chrome_elf/chrome_elf_util_unittest.cc:319: EXPECT_EQ(install_static::kChromeChannelStable, channel); On 2016/05/06 19:36:03, ananta wrote: > On ...
4 years, 7 months ago (2016-05-06 21:30:11 UTC) #44
grt (UTC plus 2)
https://codereview.chromium.org/1913943003/diff/740001/chrome_elf/chrome_elf_util_unittest.cc File chrome_elf/chrome_elf_util_unittest.cc (right): https://codereview.chromium.org/1913943003/diff/740001/chrome_elf/chrome_elf_util_unittest.cc#newcode319 chrome_elf/chrome_elf_util_unittest.cc:319: EXPECT_EQ(install_static::kChromeChannelStable, channel); On 2016/05/06 21:30:11, ananta wrote: > On ...
4 years, 7 months ago (2016-05-09 18:54:11 UTC) #45
ananta
https://codereview.chromium.org/1913943003/diff/740001/chrome_elf/chrome_elf_util_unittest.cc File chrome_elf/chrome_elf_util_unittest.cc (right): https://codereview.chromium.org/1913943003/diff/740001/chrome_elf/chrome_elf_util_unittest.cc#newcode319 chrome_elf/chrome_elf_util_unittest.cc:319: EXPECT_EQ(install_static::kChromeChannelStable, channel); On 2016/05/09 18:54:11, grt (slow) wrote: > ...
4 years, 7 months ago (2016-05-09 22:21:07 UTC) #46
grt (UTC plus 2)
lgtm (fingers crossed) https://codereview.chromium.org/1913943003/diff/800001/chrome_elf/chrome_elf_util_unittest.cc File chrome_elf/chrome_elf_util_unittest.cc (right): https://codereview.chromium.org/1913943003/diff/800001/chrome_elf/chrome_elf_util_unittest.cc#newcode282 chrome_elf/chrome_elf_util_unittest.cc:282: // We don't check for modifiers ...
4 years, 7 months ago (2016-05-10 16:04:16 UTC) #47
ananta
Thanks for the review https://codereview.chromium.org/1913943003/diff/800001/chrome_elf/chrome_elf_util_unittest.cc File chrome_elf/chrome_elf_util_unittest.cc (right): https://codereview.chromium.org/1913943003/diff/800001/chrome_elf/chrome_elf_util_unittest.cc#newcode282 chrome_elf/chrome_elf_util_unittest.cc:282: // We don't check for ...
4 years, 7 months ago (2016-05-10 19:28:18 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913943003/820001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913943003/820001
4 years, 7 months ago (2016-05-10 19:40:45 UTC) #51
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/180654)
4 years, 7 months ago (2016-05-10 19:48:52 UTC) #53
ananta
+thestig for install_static/DEPS
4 years, 7 months ago (2016-05-10 20:04:49 UTC) #55
robertshield
chrome_elf bits LGTM
4 years, 7 months ago (2016-05-10 20:07:04 UTC) #56
Lei Zhang
On 2016/05/10 20:04:49, ananta wrote: > +thestig for install_static/DEPS Do you actually need that DEPS ...
4 years, 7 months ago (2016-05-10 20:40:44 UTC) #57
ananta
On 2016/05/10 20:40:44, Lei Zhang wrote: > On 2016/05/10 20:04:49, ananta wrote: > > +thestig ...
4 years, 7 months ago (2016-05-10 21:02:32 UTC) #58
Lei Zhang
On 2016/05/10 21:02:32, ananta wrote: > On 2016/05/10 20:40:44, Lei Zhang wrote: > > On ...
4 years, 7 months ago (2016-05-10 21:11:26 UTC) #59
ananta
On 2016/05/10 21:11:26, Lei Zhang wrote: > On 2016/05/10 21:02:32, ananta wrote: > > On ...
4 years, 7 months ago (2016-05-10 21:27:40 UTC) #60
Lei Zhang
On 2016/05/10 21:27:40, ananta wrote: > Added some rules. PTAL ok, lgtm
4 years, 7 months ago (2016-05-10 21:36:28 UTC) #61
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913943003/840001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913943003/840001
4 years, 7 months ago (2016-05-10 21:47:25 UTC) #64
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/226612)
4 years, 7 months ago (2016-05-10 23:17:12 UTC) #66
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913943003/860001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913943003/860001
4 years, 7 months ago (2016-05-10 23:45:29 UTC) #69
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913943003/880001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913943003/880001
4 years, 7 months ago (2016-05-11 00:33:03 UTC) #72
commit-bot: I haz the power
Committed patchset #43 (id:880001)
4 years, 7 months ago (2016-05-11 02:36:41 UTC) #74
commit-bot: I haz the power
Patchset 43 (id:??) landed as https://crrev.com/8d6f29a4043e293c44371496e9d729e2dfacd04e Cr-Commit-Position: refs/heads/master@{#392834}
4 years, 7 months ago (2016-05-11 02:39:04 UTC) #76
tapted
4 years, 7 months ago (2016-05-11 03:57:14 UTC) #77
Message was sent while issue was closed.
A revert of this CL (patchset #43 id:880001) has been created in
https://codereview.chromium.org/1963373003/ by tapted@chromium.org.

The reason for reverting is: Suspected for breaking compile on Official Win
build since

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

with

installer_util.lib(installer_util.google_chrome_distribution.obj) :error
LNK2001: unresolved external symbol "bool __cdecl
install_static::GetDefaultCrashDumpLocation(..).

Powered by Google App Engine
This is Rietveld 408576698