Revert of Remove dependencies on chrome\installer from the ChromeCrashReporterClient class on Windows.

Revert of Remove dependencies on chrome\installer from the ChromeCrashReporterClient class on Windows. (patchset #43 id:880001 of https://codereview.chromium.org/1913943003/ )

Reason for revert:
Suspected for breaking compile on Official Win build since

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/6957

with

installer_util.lib(installer_util.google_chrome_distribution.obj) :error LNK2001: unresolved external symbol "bool __cdecl install_static::GetDefaultCrashDumpLocation(..)

Original issue's description:
> Remove dependencies on chrome\installer from the ChromeCrashReporterClient class on Windows.
>
> This is step 2 of the work underway to move the crash pad registration from chrome.exe to chrome_elf.
>
> Most of the changes in this patch are addition of helper functions to the install_static_util library
> to retrieve the channel name, user data directory, chrome version information etc. I added TODOs to
> these functions with comments that we need to consolidate these with similar functions in Chrome\installer.
>
> As install_static is pulled in by chrome_elf, we cannot depend
> on functionality in base which brings in dependencies on user32.
> This includes utf8 to utf16 conversion, pattern matching functions, etc. I added implementations of the functions
> we need to install_util.cc.
>
> Once we test this out in the field and things work well, we will move the crash pad registration into chrome_elf
>
> BUG=604923
>
> Committed: https://crrev.com/8d6f29a4043e293c44371496e9d729e2dfacd04e
> Cr-Commit-Position: refs/heads/master@{#392834}

TBR=scottmg@chromium.org,robertshield@chromium.org,sky@chromium.org,grt@chromium.org,dschuff@chromium.org,thestig@chromium.org,ananta@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=604923
Committed: https://crrev.com/6221c51d41413e9a7a26787b4bd8fe3ebabefcf9
Cr-Commit-Position: refs/heads/master@{#392843}

[tapted, 2016-05-11 03:57:15]

Created Revert of Remove dependencies on chrome\installer from the
ChromeCrashReporterClient class on Windows.

[commit-bot: I haz the power, 2016-05-11 03:58:28]

Description was changed from

==========
Revert of Remove dependencies on chrome\installer from the
ChromeCrashReporterClient class on Windows. (patchset #43 id:880001 of
https://codereview.chromium.org/1913943003/ )

Reason for revert:
Suspected for breaking compile on Official Win build since

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

with

installer_util.lib(installer_util.google_chrome_distribution.obj) :error
LNK2001: unresolved external symbol "bool __cdecl
install_static::GetDefaultCrashDumpLocation(..)

Original issue's description:
> Remove dependencies on chrome\installer from the ChromeCrashReporterClient
class on Windows.
> 
> This is step 2 of the work underway to move the crash pad registration from
chrome.exe to chrome_elf.
> 
> Most of the changes in this patch are addition of helper functions to the
install_static_util library
> to retrieve the channel name, user data directory, chrome version information
etc. I added TODOs to
> these functions with comments that we need to consolidate these with similar
functions in Chrome\installer.
> 
> As install_static is pulled in by chrome_elf, we cannot depend
> on functionality in base which brings in dependencies on user32.
> This includes utf8 to utf16 conversion, pattern matching functions, etc. I
added implementations of the functions
> we need to install_util.cc.
> 
> Once we test this out in the field and things work well, we will move the
crash pad registration into chrome_elf
> 
> BUG=604923
> 
> Committed: https://crrev.com/8d6f29a4043e293c44371496e9d729e2dfacd04e
> Cr-Commit-Position: refs/heads/master@{#392834}

TBR=scottmg@chromium.org,robertshield@chromium.org,sky@chromium.org,grt@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=604923
==========

to

==========
Revert of Remove dependencies on chrome\installer from the
ChromeCrashReporterClient class on Windows. (patchset #43 id:880001 of
https://codereview.chromium.org/1913943003/ )

Reason for revert:
Suspected for breaking compile on Official Win build since

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

with

installer_util.lib(installer_util.google_chrome_distribution.obj) :error
LNK2001: unresolved external symbol "bool __cdecl
install_static::GetDefaultCrashDumpLocation(..)

Original issue's description:
> Remove dependencies on chrome\installer from the ChromeCrashReporterClient
class on Windows.
> 
> This is step 2 of the work underway to move the crash pad registration from
chrome.exe to chrome_elf.
> 
> Most of the changes in this patch are addition of helper functions to the
install_static_util library
> to retrieve the channel name, user data directory, chrome version information
etc. I added TODOs to
> these functions with comments that we need to consolidate these with similar
functions in Chrome\installer.
> 
> As install_static is pulled in by chrome_elf, we cannot depend
> on functionality in base which brings in dependencies on user32.
> This includes utf8 to utf16 conversion, pattern matching functions, etc. I
added implementations of the functions
> we need to install_util.cc.
> 
> Once we test this out in the field and things work well, we will move the
crash pad registration into chrome_elf
> 
> BUG=604923
> 
> Committed: https://crrev.com/8d6f29a4043e293c44371496e9d729e2dfacd04e
> Cr-Commit-Position: refs/heads/master@{#392834}

TBR=scottmg@chromium.org,robertshield@chromium.org,sky@chromium.org,grt@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=604923
==========

[commit-bot: I haz the power, 2016-05-11 03:59:58]

Description was changed from

==========
Revert of Remove dependencies on chrome\installer from the
ChromeCrashReporterClient class on Windows. (patchset #43 id:880001 of
https://codereview.chromium.org/1913943003/ )

Reason for revert:
Suspected for breaking compile on Official Win build since

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

with

installer_util.lib(installer_util.google_chrome_distribution.obj) :error
LNK2001: unresolved external symbol "bool __cdecl
install_static::GetDefaultCrashDumpLocation(..)

Original issue's description:
> Remove dependencies on chrome\installer from the ChromeCrashReporterClient
class on Windows.
> 
> This is step 2 of the work underway to move the crash pad registration from
chrome.exe to chrome_elf.
> 
> Most of the changes in this patch are addition of helper functions to the
install_static_util library
> to retrieve the channel name, user data directory, chrome version information
etc. I added TODOs to
> these functions with comments that we need to consolidate these with similar
functions in Chrome\installer.
> 
> As install_static is pulled in by chrome_elf, we cannot depend
> on functionality in base which brings in dependencies on user32.
> This includes utf8 to utf16 conversion, pattern matching functions, etc. I
added implementations of the functions
> we need to install_util.cc.
> 
> Once we test this out in the field and things work well, we will move the
crash pad registration into chrome_elf
> 
> BUG=604923
> 
> Committed: https://crrev.com/8d6f29a4043e293c44371496e9d729e2dfacd04e
> Cr-Commit-Position: refs/heads/master@{#392834}

TBR=scottmg@chromium.org,robertshield@chromium.org,sky@chromium.org,grt@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=604923
==========

to

==========
Revert of Remove dependencies on chrome\installer from the
ChromeCrashReporterClient class on Windows. (patchset #43 id:880001 of
https://codereview.chromium.org/1913943003/ )

Reason for revert:
Suspected for breaking compile on Official Win build since

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

with

installer_util.lib(installer_util.google_chrome_distribution.obj) :error
LNK2001: unresolved external symbol "bool __cdecl
install_static::GetDefaultCrashDumpLocation(..)

Original issue's description:
> Remove dependencies on chrome\installer from the ChromeCrashReporterClient
class on Windows.
>
> This is step 2 of the work underway to move the crash pad registration from
chrome.exe to chrome_elf.
>
> Most of the changes in this patch are addition of helper functions to the
install_static_util library
> to retrieve the channel name, user data directory, chrome version information
etc. I added TODOs to
> these functions with comments that we need to consolidate these with similar
functions in Chrome\installer.
>
> As install_static is pulled in by chrome_elf, we cannot depend
> on functionality in base which brings in dependencies on user32.
> This includes utf8 to utf16 conversion, pattern matching functions, etc. I
added implementations of the functions
> we need to install_util.cc.
>
> Once we test this out in the field and things work well, we will move the
crash pad registration into chrome_elf
>
> BUG=604923
>
> Committed: https://crrev.com/8d6f29a4043e293c44371496e9d729e2dfacd04e
> Cr-Commit-Position: refs/heads/master@{#392834}

TBR=scottmg@chromium.org,robertshield@chromium.org,sky@chromium.org,grt@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=604923

Committed: https://crrev.com/6221c51d41413e9a7a26787b4bd8fe3ebabefcf9
Cr-Commit-Position: refs/heads/master@{#392843}
==========