Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1679913002: Run chrome_app_unittests on win bots. (Closed)

Created:
4 years, 10 months ago by grt (UTC plus 2)
Modified:
4 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run chrome_app_unittests on win bots. BUG=585151 Committed: https://crrev.com/eec2afd645b8062540937fa61e64dd1a6e980d49 Cr-Commit-Position: refs/heads/master@{#374391}

Patch Set 1 #

Total comments: 2

Patch Set 2 : gn_migration fix #

Patch Set 3 : mac and linux too #

Patch Set 4 : chrome_app_unittests on GN mac too #

Patch Set 5 : Sync to position 374371 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -15 lines) Patch
M build/gn_migration.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/chrome_app_unittests.isolate View 1 2 2 chunks +16 lines, -9 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 3 4 17 chunks +102 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 1 2 7 chunks +37 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 3 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 3 4 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 32 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679913002/1
4 years, 10 months ago (2016-02-08 20:36:03 UTC) #4
grt (UTC plus 2)
PTAL. There's a lot of monkey-see-monkey-do here, so please point out all of the things ...
4 years, 10 months ago (2016-02-08 20:40:22 UTC) #5
Nico
this lgtm with the comment addressed. Are these tests win-only? https://codereview.chromium.org/1679913002/diff/1/build/gn_migration.gypi File build/gn_migration.gypi (right): https://codereview.chromium.org/1679913002/diff/1/build/gn_migration.gypi#newcode552 ...
4 years, 10 months ago (2016-02-08 20:52:32 UTC) #6
grt (UTC plus 2)
Presently, all sources but one are _win. It would be reasonable for other platform code ...
4 years, 10 months ago (2016-02-08 21:14:25 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679913002/20001
4 years, 10 months ago (2016-02-08 21:19:44 UTC) #9
Nico
I think that'd be nicer, but up to you.
4 years, 10 months ago (2016-02-08 21:21:13 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-08 23:24:39 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679913002/40001
4 years, 10 months ago (2016-02-09 14:10:11 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/178380)
4 years, 10 months ago (2016-02-09 14:18:29 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679913002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679913002/60001
4 years, 10 months ago (2016-02-09 14:33:42 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/128384) ios_rel_device_ninja on ...
4 years, 10 months ago (2016-02-09 14:35:47 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679913002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679913002/80001
4 years, 10 months ago (2016-02-09 14:46:05 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-09 15:57:32 UTC) #24
grt (UTC plus 2)
On 2016/02/08 21:21:13, Nico wrote: > I think that'd be nicer, but up to you. ...
4 years, 10 months ago (2016-02-09 16:03:09 UTC) #25
Nico
lgtm!
4 years, 10 months ago (2016-02-09 16:05:35 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679913002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679913002/80001
4 years, 10 months ago (2016-02-09 16:38:54 UTC) #28
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-09 16:56:56 UTC) #30
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 16:58:29 UTC) #32
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/eec2afd645b8062540937fa61e64dd1a6e980d49
Cr-Commit-Position: refs/heads/master@{#374391}

Powered by Google App Engine
This is Rietveld 408576698