chrome_elf/elf_imports_unittest.cc - Issue 1913943003: Remove dependencies on chrome\installer from the ChromeCrashReporterClient class on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/elf_imports_unittest.cc

Issue 1913943003: Remove dependencies on chrome\installer from the ChromeCrashReporterClient class on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix DEPs includes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_elf/elf_imports_unittest.cc

diff --git a/chrome_elf/elf_imports_unittest.cc b/chrome_elf/elf_imports_unittest.cc

index c999932ea5cf62a9e77395398b19ba6e5a970bdd..8c3527a13858f5c2e476b3efbfb3655e400ea7d9 100644

--- a/chrome_elf/elf_imports_unittest.cc

+++ b/chrome_elf/elf_imports_unittest.cc

@@ -88,7 +88,11 @@ TEST_F(ELFImportsTest, ChromeElfSanityCheck) {

#if defined(ADDRESS_SANITIZER) && defined(COMPONENT_BUILD)

"clang_rt.asan_dynamic-i386.dll",

#endif

- "ADVAPI32.dll"

+ "ADVAPI32.dll",

+ // On 64 bit the Version API's like VerQueryValue come from VERSION.dll.

+ // It depends on kernel32, advapi32 and api-ms-win-crt*.dll. This should

+ // be ok.

+ "VERSION.dll",

};

// Make sure all of ELF's imports are in the valid imports list.

« no previous file with comments | « chrome_elf/chrome_elf_util_unittest.cc ('k') | components/nacl/broker/BUILD.gn » ('j') | no next file with comments »