Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/installer/util/BUILD.gn

Issue 1913943003: Remove dependencies on chrome\installer from the ChromeCrashReporterClient class on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix DEPs includes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/install_static/install_util.cc ('k') | chrome/installer/util/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 7
8 # This file deliberately has no default "util" target so dependants have to 8 # This file deliberately has no default "util" target so dependants have to
9 # specify with the ":with_no_strings" or ":with_rc_strings" variants. Random 9 # specify with the ":with_no_strings" or ":with_rc_strings" variants. Random
10 # code that ends up getting linked into chrome proper should depend on the 10 # code that ends up getting linked into chrome proper should depend on the
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 "user_experiment.h", 101 "user_experiment.h",
102 ] 102 ]
103 103
104 deps += [ 104 deps += [
105 # Need to depend on the generated strings target since files here 105 # Need to depend on the generated strings target since files here
106 # depend on the generated header, but only depend on the ":strings" 106 # depend on the generated header, but only depend on the ":strings"
107 # target (which actually compiles and causes the generated code to be 107 # target (which actually compiles and causes the generated code to be
108 # linked) from the ":util" target. 108 # linked) from the ":util" target.
109 ":generate_strings", 109 ":generate_strings",
110 "//base/third_party/dynamic_annotations", 110 "//base/third_party/dynamic_annotations",
111 "//chrome/install_static:install_static_util",
111 "//components/metrics", 112 "//components/metrics",
112 113
113 # TODO(fdoray): Remove this once the PreRead field trial has expired. 114 # TODO(fdoray): Remove this once the PreRead field trial has expired.
114 # crbug.com/577698 115 # crbug.com/577698
115 "//components/startup_metric_utils/common", 116 "//components/startup_metric_utils/common",
116 "//courgette:courgette_lib", 117 "//courgette:courgette_lib",
117 "//crypto", 118 "//crypto",
118 "//third_party/bspatch", 119 "//third_party/bspatch",
119 "//third_party/crashpad/crashpad/client", 120 "//third_party/crashpad/crashpad/client",
120 "//third_party/icu", 121 "//third_party/icu",
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 ] 353 ]
353 354
354 data = [ 355 data = [
355 "//chrome/test/data/extensions/", 356 "//chrome/test/data/extensions/",
356 "//chrome/test/data/installer/", 357 "//chrome/test/data/installer/",
357 ] 358 ]
358 359
359 # TODO(GYP) manifest: $(ProjectDir)\\installer\\mini_installer\\mini_install er.exe.manifest 360 # TODO(GYP) manifest: $(ProjectDir)\\installer\\mini_installer\\mini_install er.exe.manifest
360 } 361 }
361 } # is_win 362 } # is_win
OLDNEW
« no previous file with comments | « chrome/install_static/install_util.cc ('k') | chrome/installer/util/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698