third_party/WebKit/Source/core/workers/WorkerThread.cpp - Issue 1913283003: [DevTools] Rework idle{Started,Finished} instrumentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThread.cpp

Issue 1913283003: [DevTools] Rework idle{Started,Finished} instrumentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1907663005

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerThread.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerThread.cpp b/third_party/WebKit/Source/core/workers/WorkerThread.cpp

index 28bd0b050f3d9f8dcd5b72fbeaecf6a22c8bd448..9de7c21a9fe3d664d3f257319d4dd3983338676b 100644

--- a/third_party/WebKit/Source/core/workers/WorkerThread.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerThread.cpp

@@ -421,9 +421,9 @@ void WorkerThread::runDebuggerTask(PassOwnPtr<CrossThreadClosure> task)

MutexLocker lock(m_threadStateMutex);

m_runningDebuggerTask = true;

}

- InspectorInstrumentation::willProcessTask(workerGlobalScope());

+ ThreadDebugger::idleFinished(isolate());

(*task)();

- InspectorInstrumentation::didProcessTask(workerGlobalScope());

+ ThreadDebugger::idleStarted(isolate());

{

MutexLocker lock(m_threadStateMutex);

m_runningDebuggerTask = false;

@@ -437,7 +437,7 @@ void WorkerThread::runDebuggerTask(PassOwnPtr<CrossThreadClosure> task)

void WorkerThread::startRunningDebuggerTasksOnPause()

{

m_pausedInDebugger = true;

- InspectorInstrumentation::willEnterNestedRunLoop(m_workerGlobalScope.get());

+ ThreadDebugger::idleStarted(isolate());

OwnPtr<CrossThreadClosure> task;

do {

{

@@ -448,7 +448,7 @@ void WorkerThread::startRunningDebuggerTasksOnPause()

(*task)();

// Keep waiting until execution is resumed.

} while (task && m_pausedInDebugger);

- InspectorInstrumentation::didLeaveNestedRunLoop(m_workerGlobalScope.get());

+ ThreadDebugger::idleFinished(isolate());

}

void WorkerThread::stopRunningDebuggerTasksOnPause()