Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 1913283003: [DevTools] Rework idle{Started,Finished} instrumentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1907663005
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8ProfilerAgent.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 631 matching lines...) Expand 10 before | Expand all | Expand 10 after
642 void WebDevToolsAgentImpl::flushPendingProtocolNotifications() 642 void WebDevToolsAgentImpl::flushPendingProtocolNotifications()
643 { 643 {
644 if (m_session) 644 if (m_session)
645 m_session->flushPendingProtocolNotifications(); 645 m_session->flushPendingProtocolNotifications();
646 } 646 }
647 647
648 void WebDevToolsAgentImpl::willProcessTask() 648 void WebDevToolsAgentImpl::willProcessTask()
649 { 649 {
650 if (!attached()) 650 if (!attached())
651 return; 651 return;
652 InspectorInstrumentation::willProcessTask(m_inspectedFrames->root()); 652 ThreadDebugger::idleFinished(V8PerIsolateData::mainThreadIsolate());
653 } 653 }
654 654
655 void WebDevToolsAgentImpl::didProcessTask() 655 void WebDevToolsAgentImpl::didProcessTask()
656 { 656 {
657 if (!attached()) 657 if (!attached())
658 return; 658 return;
659 InspectorInstrumentation::didProcessTask(m_inspectedFrames->root()); 659 ThreadDebugger::idleStarted(V8PerIsolateData::mainThreadIsolate());
660 flushPendingProtocolNotifications(); 660 flushPendingProtocolNotifications();
661 } 661 }
662 662
663 void WebDevToolsAgentImpl::runDebuggerTask(int sessionId, PassOwnPtr<WebDevTools Agent::MessageDescriptor> descriptor) 663 void WebDevToolsAgentImpl::runDebuggerTask(int sessionId, PassOwnPtr<WebDevTools Agent::MessageDescriptor> descriptor)
664 { 664 {
665 WebDevToolsAgent* webagent = descriptor->agent(); 665 WebDevToolsAgent* webagent = descriptor->agent();
666 if (!webagent) 666 if (!webagent)
667 return; 667 return;
668 668
669 WebDevToolsAgentImpl* agentImpl = static_cast<WebDevToolsAgentImpl*>(webagen t); 669 WebDevToolsAgentImpl* agentImpl = static_cast<WebDevToolsAgentImpl*>(webagen t);
(...skipping 13 matching lines...) Expand all
683 if (!protocol::Dispatcher::getCommandName(message, &commandName)) 683 if (!protocol::Dispatcher::getCommandName(message, &commandName))
684 return false; 684 return false;
685 return commandName == "Debugger.pause" 685 return commandName == "Debugger.pause"
686 || commandName == "Debugger.setBreakpoint" 686 || commandName == "Debugger.setBreakpoint"
687 || commandName == "Debugger.setBreakpointByUrl" 687 || commandName == "Debugger.setBreakpointByUrl"
688 || commandName == "Debugger.removeBreakpoint" 688 || commandName == "Debugger.removeBreakpoint"
689 || commandName == "Debugger.setBreakpointsActive"; 689 || commandName == "Debugger.setBreakpointsActive";
690 } 690 }
691 691
692 } // namespace blink 692 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8ProfilerAgent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698