Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1912243003: [Findit] Add more tests to improve code coverage. (Closed)

Created:
4 years, 8 months ago by stgao
Modified:
4 years, 8 months ago
Reviewers:
chanli, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Add more tests to improve code coverage. BUG=604505, 604096 Committed: https://chromium.googlesource.com/infra/infra/+/10badb1fe325e9668f698baf3307fc5f1c287821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -3 lines) Patch
M appengine/findit/handlers/build_failure.py View 3 chunks +2 lines, -2 lines 0 comments Download
M appengine/findit/handlers/test/build_failure_test.py View 1 chunk +52 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/detect_first_failure_pipeline.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
stgao
ptal when you have a cycle.
4 years, 8 months ago (2016-04-22 21:04:56 UTC) #2
lijeffrey
lgtm
4 years, 8 months ago (2016-04-25 00:50:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912243003/1
4 years, 8 months ago (2016-04-25 18:05:14 UTC) #5
commit-bot: I haz the power
Failed to commit the patch.
4 years, 8 months ago (2016-04-25 18:09:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912243003/1
4 years, 8 months ago (2016-04-25 18:25:44 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 18:28:21 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/10badb1fe325e9668f698baf3307f...

Powered by Google App Engine
This is Rietveld 408576698