[Findit] Add more tests to improve code coverage.

appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import json
 import os
 import urllib
 import zlib
 
 from common.http_client_appengine import HttpClientAppengine as HttpClient
 from common.pipeline_wrapper import pipeline_handlers
+from common.waterfall import failure_type
 from model import analysis_status
 from model.wf_analysis import WfAnalysis
 from model.wf_build import WfBuild
 from model.wf_step import WfStep
 from waterfall import buildbot
 from waterfall import lock_util
 from waterfall import swarming_util
+from waterfall.build_info import BuildInfo
 from waterfall.detect_first_failure_pipeline import DetectFirstFailurePipeline
 from waterfall.test import wf_testcase
 
 
 class DetectFirstFailureTest(wf_testcase.WaterfallTestCase):
   app_module = pipeline_handlers._APP
 
   def setUp(self):
     super(DetectFirstFailureTest, self).setUp()
 
@@ skipping 629 matching lines @@
         221: '{"Unittest3.Subtest3": "YS9iL3UzczIuY2M6MTEwOiBGYWlsdXJlCg=="}'
     }
 
     for n in xrange(223, 220, -1):
       step = WfStep.Get(master_name, builder_name, n, 'abc_test')
       self.assertIsNotNone(step)
       self.assertTrue(step.isolated)
       self.assertEqual(expected_step_log_data[n], step.log_data)
 
     self.assertEqual(expected_failed_steps, failure_info['failed_steps'])
+
+  def testGetFailureType(self):
+    cases = {
+        failure_type.UNKNOWN: [],
+        failure_type.COMPILE: ['compile', 'slave_steps'],
+        failure_type.TEST: ['browser_tests'],
+    }
+    for expected_type, failed_steps in cases.iteritems():
+      build_info = BuildInfo('m', 'b', 123)
+      build_info.failed_steps = failed_steps
+      self.assertEqual(
+          expected_type, DetectFirstFailurePipeline._GetFailureType(build_info))