Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2760)

Unified Diff: appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py

Issue 1912243003: [Findit] Add more tests to improve code coverage. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/waterfall/detect_first_failure_pipeline.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py b/appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py
index c5c3ec765c39f008df7e5604d9f9ac64432d6e02..f7ce060f63673a3454fa37af3ed0c39ed3a88fb2 100644
--- a/appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py
+++ b/appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py
@@ -10,6 +10,7 @@ import zlib
from common.http_client_appengine import HttpClientAppengine as HttpClient
from common.pipeline_wrapper import pipeline_handlers
+from common.waterfall import failure_type
from model import analysis_status
from model.wf_analysis import WfAnalysis
from model.wf_build import WfBuild
@@ -17,6 +18,7 @@ from model.wf_step import WfStep
from waterfall import buildbot
from waterfall import lock_util
from waterfall import swarming_util
+from waterfall.build_info import BuildInfo
from waterfall.detect_first_failure_pipeline import DetectFirstFailurePipeline
from waterfall.test import wf_testcase
@@ -666,3 +668,15 @@ class DetectFirstFailureTest(wf_testcase.WaterfallTestCase):
self.assertEqual(expected_step_log_data[n], step.log_data)
self.assertEqual(expected_failed_steps, failure_info['failed_steps'])
+
+ def testGetFailureType(self):
+ cases = {
+ failure_type.UNKNOWN: [],
+ failure_type.COMPILE: ['compile', 'slave_steps'],
+ failure_type.TEST: ['browser_tests'],
+ }
+ for expected_type, failed_steps in cases.iteritems():
+ build_info = BuildInfo('m', 'b', 123)
+ build_info.failed_steps = failed_steps
+ self.assertEqual(
+ expected_type, DetectFirstFailurePipeline._GetFailureType(build_info))
« no previous file with comments | « appengine/findit/waterfall/detect_first_failure_pipeline.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698