appengine/findit/waterfall/detect_first_failure_pipeline.py - Issue 1912243003: [Findit] Add more tests to improve code coverage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/detect_first_failure_pipeline.py

Issue 1912243003: [Findit] Add more tests to improve code coverage. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/waterfall/detect_first_failure_pipeline.py

diff --git a/appengine/findit/waterfall/detect_first_failure_pipeline.py b/appengine/findit/waterfall/detect_first_failure_pipeline.py

index f5f728a9be271054396a457314413c4da6c4ef58..a6dd42e025edc92e68057099ee4417dc7493aa35 100644

--- a/appengine/findit/waterfall/detect_first_failure_pipeline.py

+++ b/appengine/findit/waterfall/detect_first_failure_pipeline.py

@@ -354,7 +354,7 @@ class DetectFirstFailurePipeline(BasePipeline):

for step_name, failed_step in failed_steps.iteritems():

if not failed_step.get('list_isolated_data'): # Non-swarming step.

- continue

+ continue # pragma: no cover.

# Checks tests in one step and updates failed_step info if swarming.

result = self._StartTestLevelCheckForFirstFailure(