[Findit] Add more tests to improve code coverage.

appengine/findit/handlers/build_failure.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import copy
 from datetime import datetime
 import logging
 import os
 
@@ skipping 276 matching lines @@
         'analysis_request_time': _FormatDatetime(analysis.request_time),
         'analysis_start_time': _FormatDatetime(analysis.start_time),
         'analysis_end_time': _FormatDatetime(analysis.end_time),
         'analysis_duration': analysis.duration,
         'analysis_update_time': _FormatDatetime(analysis.updated_time),
         'analysis_completed': analysis.completed,
         'analysis_failed': analysis.failed,
         'analysis_correct': analysis.correct,
         'triage_history': _GetTriageHistory(analysis),
         'show_triage_help_button': self._ShowTriageHelpButton(),
-        'status_message_map': result_status.STATUS_MESSAGE_MAP
     }
 
   @staticmethod
   def _PrepareTryJobDataForCompileFailure(analysis):
     try_job_data = {}
     if not (analysis.failure_result_map and  # pragma: no branch.
             constants.COMPILE_STEP_NAME in analysis.failure_result_map):
       return try_job_data  # pragma: no cover.
 
     referred_build_keys = analysis.failure_result_map[
@@ skipping 30 matching lines @@
 
     # Check result from heuristic analysis.
     self._PopulateHeuristicDataForCompileFailure(analysis, data)
     # Check result from try job.
     data['try_job'] = self._PrepareTryJobDataForCompileFailure(analysis)
 
     return data
 
   def _PrepareDataForTestFailures(self, analysis, build_info):
     data = self._PrepareCommonDataForFailure(analysis)
+    data['status_message_map'] = result_status.STATUS_MESSAGE_MAP
 
     organized_results = _GetOrganizedAnalysisResultBySuspectedCL(
         analysis.result)
     analysis_result = _GetAnalysisResultWithTryJobInfo(
         organized_results, *build_info)
     data['analysis_result'] = analysis_result
 
     return data
 
   def HandleGet(self):
@@ skipping 25 matching lines @@
       # Only allow admin to force a re-run and set the build_completed.
       force = (users.is_current_user_admin() and
                self.request.get('force') == '1')
       build_completed = (users.is_current_user_admin() and
                          self.request.get('build_completed') == '1')
       analysis = build_failure_analysis_pipelines.ScheduleAnalysisIfNeeded(
           master_name, builder_name, build_number,
           build_completed=build_completed, force=force,
           queue_name=constants.WATERFALL_ANALYSIS_QUEUE)
 
-    if analysis.failure_type == failure_type.COMPILE:  # pragma: no branch
+    if analysis.failure_type == failure_type.COMPILE:
       return {
         'template': 'waterfall/compile_failure.html',
         'data': self._PrepareDataForCompileFailure(analysis),
       }
     else:
       return {
         'template': 'build_failure.html',
         'data': self._PrepareDataForTestFailures(analysis, build_info),
       }
 
   def HandlePost(self):  # pragma: no cover
     return self.HandleGet()