Convert //media/audio from scoped_ptr to std::unique_ptr

Convert //media/audio from scoped_ptr to std::unique_ptr

BUG=554298
R=danakj@chromium.org
TBR=brettw@chromium.org

Committed: https://crrev.com/7089de047f9845b19afd5b671ace13aa1aa3ad42
Cr-Commit-Position: refs/heads/master@{#389347}

[dcheng, 2016-04-22 22:29:44]

dcheng@chromium.org changed reviewers:
+ brettw@chromium.org, danakj@chromium.org

[dcheng, 2016-04-22 22:29:45]

+danakj@ for sanity check
+brettw@ for TBR global stamp

[dcheng, 2016-04-22 22:29:57]

Description was changed from

==========
Convert //media/audio from scoped_ptr to std::unique_ptr

BUG=554298
R=miu@chromium.org
==========

to

==========
Convert //media/audio from scoped_ptr to std::unique_ptr

BUG=554298
R=danakj@chromium.org
TBR=brettw@chromium.org
==========

[danakj, 2016-04-22 22:47:38]

Sorry for the IWYU horrorshow.

https://codereview.chromium.org/1911913002/diff/20001/chromecast/media/audio/...
File chromecast/media/audio/cast_audio_manager_factory.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/chromecast/media/audio/...
chromecast/media/audio/cast_audio_manager_factory.cc:25: return
std::unique_ptr<::media::AudioManager, ::media::AudioManagerDeleter>(
include memory, or use WrapUnique

https://codereview.chromium.org/1911913002/diff/20001/media/audio/agc_audio_s...
File media/audio/agc_audio_stream.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/agc_audio_s...
media/audio/agc_audio_stream.h:8: #include <memory>
unused

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/alsa_i...
File media/audio/alsa/alsa_input.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/alsa_i...
media/audio/alsa/alsa_input.h:87: audio_buffer_;  // Buffer used for reading
audio data.
move the comment above the variable to its own line for less insane formating

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/alsa_o...
File media/audio/alsa/alsa_output.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/alsa_o...
media/audio/alsa/alsa_output.cc:564: std::unique_ptr<char, base::FreeDeleter>
io(
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/audio_...
File media/audio/alsa/audio_manager_alsa.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/audio_...
media/audio/alsa/audio_manager_alsa.cc:56: std::unique_ptr<base::Environment>
env(base::Environment::Create());
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/audio_...
File media/audio/alsa/audio_manager_alsa.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/audio_...
media/audio/alsa/audio_manager_alsa.h:90: std::unique_ptr<AlsaWrapper> wrapper_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/android/aud...
File media/audio/android/audio_record_input.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/android/aud...
media/audio/android/audio_record_input.h:78: std::unique_ptr<media::AudioBus>
audio_bus_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/android/ope...
File media/audio/android/opensles_input.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/android/ope...
media/audio/android/opensles_input.h:101: std::unique_ptr<media::AudioBus>
audio_bus_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/android/ope...
File media/audio/android/opensles_output.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/android/ope...
media/audio/android/opensles_output.h:121: std::unique_ptr<AudioBus> audio_bus_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_devic...
File media/audio/audio_device_thread.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_devic...
media/audio/audio_device_thread.h:10: #include <memory>
unused

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_input...
File media/audio/audio_input_controller.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_input...
media/audio/audio_input_controller.cc:518: std::unique_ptr<AudioBus> source_copy
=
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_input...
File media/audio/audio_input_device.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_input...
media/audio/audio_input_device.cc:298: std::unique_ptr<media::AudioBus>
audio_bus =
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_manag...
File media/audio/audio_manager.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_manag...
media/audio/audio_manager.cc:256:
std::unique_ptr<base::win::ScopedCOMInitializer> com_initializer_for_testing_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_manag...
File media/audio/audio_manager.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_manag...
media/audio/audio_manager.h:258: virtual std::unique_ptr<AudioLog>
CreateAudioLog(
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
File media/audio/audio_output_controller.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
media/audio/audio_output_controller.h:259: std::unique_ptr<base::OneShotTimer>
wedge_timer_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
File media/audio/audio_output_device_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
media/audio/audio_output_device_unittest.cc:144:
std::unique_ptr<AudioOutputIPC>(audio_output_ipc_),
include memory or WrapUnique

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
File media/audio/audio_output_dispatcher_impl.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
media/audio/audio_output_dispatcher_impl.h:94: std::unique_ptr<AudioLog>
audio_log_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
File media/audio/audio_output_proxy_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
media/audio/audio_output_proxy_unittest.cc:86:
std::unique_ptr<AudioOutputStream> fake_output_stream_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_power...
File media/audio/audio_power_monitor_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_power...
media/audio/audio_power_monitor_unittest.cc:79: std::unique_ptr<AudioBus> bus_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/clockless_a...
File media/audio/clockless_audio_sink.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/clockless_a...
media/audio/clockless_audio_sink.cc:70: std::unique_ptr<AudioBus> audio_bus_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/cras/cras_i...
File media/audio/cras/cras_input.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/cras/cras_i...
media/audio/cras/cras_input.h:113: std::unique_ptr<AudioBus> audio_bus_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/cras/cras_u...
File media/audio/cras/cras_unified.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/cras/cras_u...
media/audio/cras/cras_unified.h:109: std::unique_ptr<AudioBus> output_bus_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/cras/cras_u...
File media/audio/cras/cras_unified_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/cras/cras_u...
media/audio/cras/cras_unified_unittest.cc:101:
std::unique_ptr<StrictMock<MockAudioManagerCras>, AudioManagerDeleter>
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/fake_audio_...
File media/audio/fake_audio_log_factory.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/fake_audio_...
media/audio/fake_audio_log_factory.cc:32: return std::unique_ptr<AudioLog>(new
FakeAudioLogImpl());
include memory or WrapUnique

https://codereview.chromium.org/1911913002/diff/20001/media/audio/fake_audio_...
File media/audio/fake_audio_worker.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/fake_audio_...
media/audio/fake_audio_worker.cc:7: #include <memory>
unused

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_a...
File media/audio/mac/audio_auhal_mac.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_a...
media/audio/mac/audio_auhal_mac.h:181: std::unique_ptr<AudioBus> output_bus_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_a...
File media/audio/mac/audio_auhal_mac_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_a...
media/audio/mac/audio_auhal_mac_unittest.cc:5: #include <memory>
unused

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_i...
File media/audio/mac/audio_input_mac.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_i...
media/audio/mac/audio_input_mac.h:90: std::unique_ptr<media::AudioBus>
audio_bus_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_l...
File media/audio/mac/audio_low_latency_input_mac_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_l...
media/audio/mac/audio_low_latency_input_mac_unittest.cc:85:
std::unique_ptr<int16_t> interleaved(new int16_t[num_samples]);
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_m...
File media/audio/mac/audio_manager_mac.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_m...
media/audio/mac/audio_manager_mac.cc:136: std::unique_ptr<AudioDeviceID,
base::FreeDeleter> devices(
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_m...
File media/audio/mac/audio_manager_mac.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_m...
media/audio/mac/audio_manager_mac.h:128: std::unique_ptr<AudioDeviceListenerMac>
output_device_listener_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mock_audio_...
File media/audio/mock_audio_manager.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mock_audio_...
media/audio/mock_audio_manager.cc:95: return std::unique_ptr<AudioLog>();
nit: nullptr

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mock_audio_...
File media/audio/mock_audio_manager.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mock_audio_...
media/audio/mock_audio_manager.h:58: std::unique_ptr<AudioLog> CreateAudioLog(
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/simple_sour...
File media/audio/simple_sources.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/simple_sour...
media/audio/simple_sources.cc:43: std::unique_ptr<char[]> data(new
char[wav_file_length]);
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/simple_sour...
File media/audio/simple_sources.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/simple_sour...
media/audio/simple_sources.h:75: std::unique_ptr<char[]> raw_wav_data_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/sounds/audi...
File media/audio/sounds/audio_stream_handler.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/sounds/audi...
media/audio/sounds/audio_stream_handler.cc:174: std::unique_ptr<WavAudioHandler>
wav_audio =
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/sounds/wav_...
File media/audio/sounds/wav_audio_handler.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/sounds/wav_...
media/audio/sounds/wav_audio_handler.cc:185: return
std::unique_ptr<WavAudioHandler>();
include memory, or nullptr

https://codereview.chromium.org/1911913002/diff/20001/media/audio/virtual_aud...
File media/audio/virtual_audio_input_stream_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/virtual_aud...
media/audio/virtual_audio_input_stream_unittest.cc:231:
std::unique_ptr<base::Thread> audio_thread_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/virtual_aud...
File media/audio/virtual_audio_output_stream_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/virtual_aud...
media/audio/virtual_audio_output_stream_unittest.cc:71:
std::unique_ptr<base::Thread> audio_thread_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/audio_l...
File media/audio/win/audio_low_latency_input_win.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/audio_l...
media/audio/win/audio_low_latency_input_win.h:207:
std::unique_ptr<media::AudioBus> audio_bus_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/audio_m...
File media/audio/win/audio_manager_win.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/audio_m...
media/audio/win/audio_manager_win.h:95: std::unique_ptr<AudioDeviceListenerWin>
output_device_listener_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/audio_o...
File media/audio/win/audio_output_win_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/audio_o...
media/audio/win/audio_output_win_unittest.cc:552: std::unique_ptr<float,
base::AlignedFreeDeleter> data_;
include memory

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/core_au...
File media/audio/win/core_audio_util_win_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/core_au...
media/audio/win/core_audio_util_win_unittest.cc:10: #include <memory>
unused

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/wavein_...
File media/audio/win/wavein_input_win.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/wavein_...
media/audio/win/wavein_input_win.h:131: std::unique_ptr<media::AudioBus>
audio_bus_;
include memory

[miu, 2016-04-22 22:49:16]

lgtm

[dcheng, 2016-04-22 23:13:21]

https://codereview.chromium.org/1911913002/diff/20001/chromecast/media/audio/...
File chromecast/media/audio/cast_audio_manager_factory.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/chromecast/media/audio/...
chromecast/media/audio/cast_audio_manager_factory.cc:25: return
std::unique_ptr<::media::AudioManager, ::media::AudioManagerDeleter>(
On 2016/04/22 at 22:47:35, danakj wrote:
> include memory, or use WrapUnique

Can't use WrapUnique due to the custom deleter. Here's the fun part. From
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes:
"If you rely on symbols from bar.h, don't count on the fact that you included
foo.h which (currently) includes bar.h: include bar.h yourself, unless foo.h
explicitly demonstrates its intent to provide you the symbols of bar.h."

Does interface.h demonstrate an intent to specifically expose headers like
<memory> to us? I feel like you could argue either way on this one.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/agc_audio_s...
File media/audio/agc_audio_stream.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/agc_audio_s...
media/audio/agc_audio_stream.h:8: #include <memory>
On 2016/04/22 at 22:47:35, danakj wrote:
> unused

Done. I hope this doesn't trigger a chain of fun.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/alsa_i...
File media/audio/alsa/alsa_input.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/alsa_i...
media/audio/alsa/alsa_input.h:87: audio_buffer_;  // Buffer used for reading
audio data.
On 2016/04/22 at 22:47:35, danakj wrote:
> move the comment above the variable to its own line for less insane formating

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/alsa_o...
File media/audio/alsa/alsa_output.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/alsa_o...
media/audio/alsa/alsa_output.cc:564: std::unique_ptr<char, base::FreeDeleter>
io(
On 2016/04/22 at 22:47:35, danakj wrote:
> include memory

I shall invoke the style guide here:
"However, any includes present in the related header do not need to be included
again in the related cc (i.e., foo.cc can rely on foo.h's includes)."

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/audio_...
File media/audio/alsa/audio_manager_alsa.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/audio_...
media/audio/alsa/audio_manager_alsa.cc:56: std::unique_ptr<base::Environment>
env(base::Environment::Create());
On 2016/04/22 at 22:47:35, danakj wrote:
> include memory

Already included in corresponding .h.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/audio_...
File media/audio/alsa/audio_manager_alsa.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/audio_...
media/audio/alsa/audio_manager_alsa.h:90: std::unique_ptr<AlsaWrapper> wrapper_;
On 2016/04/22 at 22:47:35, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/android/aud...
File media/audio/android/audio_record_input.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/android/aud...
media/audio/android/audio_record_input.h:78: std::unique_ptr<media::AudioBus>
audio_bus_;
On 2016/04/22 at 22:47:35, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/android/ope...
File media/audio/android/opensles_input.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/android/ope...
media/audio/android/opensles_input.h:101: std::unique_ptr<media::AudioBus>
audio_bus_;
On 2016/04/22 at 22:47:35, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/android/ope...
File media/audio/android/opensles_output.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/android/ope...
media/audio/android/opensles_output.h:121: std::unique_ptr<AudioBus> audio_bus_;
On 2016/04/22 at 22:47:35, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_devic...
File media/audio/audio_device_thread.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_devic...
media/audio/audio_device_thread.h:10: #include <memory>
On 2016/04/22 at 22:47:35, danakj wrote:
> unused

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_input...
File media/audio/audio_input_controller.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_input...
media/audio/audio_input_controller.cc:518: std::unique_ptr<AudioBus> source_copy
=
On 2016/04/22 at 22:47:35, danakj wrote:
> include memory

Already included in related header.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_input...
File media/audio/audio_input_device.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_input...
media/audio/audio_input_device.cc:298: std::unique_ptr<media::AudioBus>
audio_bus =
On 2016/04/22 at 22:47:35, danakj wrote:
> include memory

Already included in related header.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_manag...
File media/audio/audio_manager.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_manag...
media/audio/audio_manager.cc:256:
std::unique_ptr<base::win::ScopedCOMInitializer> com_initializer_for_testing_;
On 2016/04/22 at 22:47:35, danakj wrote:
> include memory

Already included in related header.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_manag...
File media/audio/audio_manager.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_manag...
media/audio/audio_manager.h:258: virtual std::unique_ptr<AudioLog>
CreateAudioLog(
On 2016/04/22 at 22:47:36, danakj wrote:
> include memory

Already included by some kind soul

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
File media/audio/audio_output_controller.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
media/audio/audio_output_controller.h:259: std::unique_ptr<base::OneShotTimer>
wedge_timer_;
On 2016/04/22 at 22:47:36, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
File media/audio/audio_output_device_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
media/audio/audio_output_device_unittest.cc:144:
std::unique_ptr<AudioOutputIPC>(audio_output_ipc_),
On 2016/04/22 at 22:47:36, danakj wrote:
> include memory or WrapUnique

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
File media/audio/audio_output_dispatcher_impl.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
media/audio/audio_output_dispatcher_impl.h:94: std::unique_ptr<AudioLog>
audio_log_;
On 2016/04/22 at 22:47:36, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
File media/audio/audio_output_proxy_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_outpu...
media/audio/audio_output_proxy_unittest.cc:86:
std::unique_ptr<AudioOutputStream> fake_output_stream_;
On 2016/04/22 at 22:47:36, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_power...
File media/audio/audio_power_monitor_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/audio_power...
media/audio/audio_power_monitor_unittest.cc:79: std::unique_ptr<AudioBus> bus_;
On 2016/04/22 at 22:47:36, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/clockless_a...
File media/audio/clockless_audio_sink.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/clockless_a...
media/audio/clockless_audio_sink.cc:70: std::unique_ptr<AudioBus> audio_bus_;
On 2016/04/22 at 22:47:36, danakj wrote:
> include memory

Related header.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/cras/cras_i...
File media/audio/cras/cras_input.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/cras/cras_i...
media/audio/cras/cras_input.h:113: std::unique_ptr<AudioBus> audio_bus_;
On 2016/04/22 at 22:47:36, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/cras/cras_u...
File media/audio/cras/cras_unified.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/cras/cras_u...
media/audio/cras/cras_unified.h:109: std::unique_ptr<AudioBus> output_bus_;
On 2016/04/22 at 22:47:36, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/cras/cras_u...
File media/audio/cras/cras_unified_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/cras/cras_u...
media/audio/cras/cras_unified_unittest.cc:101:
std::unique_ptr<StrictMock<MockAudioManagerCras>, AudioManagerDeleter>
On 2016/04/22 at 22:47:36, danakj wrote:
> include memory

'related header'? I could see this one going either way though. I added it.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/fake_audio_...
File media/audio/fake_audio_log_factory.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/fake_audio_...
media/audio/fake_audio_log_factory.cc:32: return std::unique_ptr<AudioLog>(new
FakeAudioLogImpl());
On 2016/04/22 at 22:47:36, danakj wrote:
> include memory or WrapUnique

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/fake_audio_...
File media/audio/fake_audio_worker.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/fake_audio_...
media/audio/fake_audio_worker.cc:7: #include <memory>
On 2016/04/22 at 22:47:36, danakj wrote:
> unused

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_a...
File media/audio/mac/audio_auhal_mac.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_a...
media/audio/mac/audio_auhal_mac.h:181: std::unique_ptr<AudioBus> output_bus_;
On 2016/04/22 at 22:47:36, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_a...
File media/audio/mac/audio_auhal_mac_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_a...
media/audio/mac/audio_auhal_mac_unittest.cc:5: #include <memory>
On 2016/04/22 at 22:47:36, danakj wrote:
> unused

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_i...
File media/audio/mac/audio_input_mac.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_i...
media/audio/mac/audio_input_mac.h:90: std::unique_ptr<media::AudioBus>
audio_bus_;
On 2016/04/22 at 22:47:37, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_l...
File media/audio/mac/audio_low_latency_input_mac_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_l...
media/audio/mac/audio_low_latency_input_mac_unittest.cc:85:
std::unique_ptr<int16_t> interleaved(new int16_t[num_samples]);
On 2016/04/22 at 22:47:37, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_m...
File media/audio/mac/audio_manager_mac.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mac/audio_m...
media/audio/mac/audio_manager_mac.cc:136: std::unique_ptr<AudioDeviceID,
base::FreeDeleter> devices(
On 2016/04/22 at 22:47:37, danakj wrote:
> include memory

Already in related header.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mock_audio_...
File media/audio/mock_audio_manager.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mock_audio_...
media/audio/mock_audio_manager.cc:95: return std::unique_ptr<AudioLog>();
On 2016/04/22 at 22:47:37, danakj wrote:
> nit: nullptr

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mock_audio_...
File media/audio/mock_audio_manager.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/mock_audio_...
media/audio/mock_audio_manager.h:58: std::unique_ptr<AudioLog> CreateAudioLog(
On 2016/04/22 at 22:47:37, danakj wrote:
> include memory

This one is weird. It's purely for an override... so its base class must be
doing the right thing, right?

https://codereview.chromium.org/1911913002/diff/20001/media/audio/simple_sour...
File media/audio/simple_sources.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/simple_sour...
media/audio/simple_sources.cc:43: std::unique_ptr<char[]> data(new
char[wav_file_length]);
On 2016/04/22 at 22:47:37, danakj wrote:
> include memory

Already in related header.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/simple_sour...
File media/audio/simple_sources.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/simple_sour...
media/audio/simple_sources.h:75: std::unique_ptr<char[]> raw_wav_data_;
On 2016/04/22 at 22:47:37, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/sounds/audi...
File media/audio/sounds/audio_stream_handler.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/sounds/audi...
media/audio/sounds/audio_stream_handler.cc:174: std::unique_ptr<WavAudioHandler>
wav_audio =
On 2016/04/22 at 22:47:37, danakj wrote:
> include memory

Done (but in related header instead)

https://codereview.chromium.org/1911913002/diff/20001/media/audio/sounds/wav_...
File media/audio/sounds/wav_audio_handler.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/sounds/wav_...
media/audio/sounds/wav_audio_handler.cc:185: return
std::unique_ptr<WavAudioHandler>();
On 2016/04/22 at 22:47:37, danakj wrote:
> include memory, or nullptr

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/virtual_aud...
File media/audio/virtual_audio_input_stream_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/virtual_aud...
media/audio/virtual_audio_input_stream_unittest.cc:231:
std::unique_ptr<base::Thread> audio_thread_;
On 2016/04/22 at 22:47:37, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/virtual_aud...
File media/audio/virtual_audio_output_stream_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/virtual_aud...
media/audio/virtual_audio_output_stream_unittest.cc:71:
std::unique_ptr<base::Thread> audio_thread_;
On 2016/04/22 at 22:47:37, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/audio_l...
File media/audio/win/audio_low_latency_input_win.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/audio_l...
media/audio/win/audio_low_latency_input_win.h:207:
std::unique_ptr<media::AudioBus> audio_bus_;
On 2016/04/22 at 22:47:37, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/audio_m...
File media/audio/win/audio_manager_win.h (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/audio_m...
media/audio/win/audio_manager_win.h:95: std::unique_ptr<AudioDeviceListenerWin>
output_device_listener_;
On 2016/04/22 at 22:47:37, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/audio_o...
File media/audio/win/audio_output_win_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/audio_o...
media/audio/win/audio_output_win_unittest.cc:552: std::unique_ptr<float,
base::AlignedFreeDeleter> data_;
On 2016/04/22 at 22:47:38, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/core_au...
File media/audio/win/core_audio_util_win_unittest.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/win/core_au...
media/audio/win/core_audio_util_win_unittest.cc:10: #include <memory>
On 2016/04/22 at 22:47:38, danakj wrote:
> unused

Done.

[danakj, 2016-04-22 23:15:16]

https://codereview.chromium.org/1911913002/diff/20001/chromecast/media/audio/...
File chromecast/media/audio/cast_audio_manager_factory.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/chromecast/media/audio/...
chromecast/media/audio/cast_audio_manager_factory.cc:25: return
std::unique_ptr<::media::AudioManager, ::media::AudioManagerDeleter>(
On 2016/04/22 23:13:19, dcheng wrote:
> On 2016/04/22 at 22:47:35, danakj wrote:
> > include memory, or use WrapUnique
> 
> Can't use WrapUnique due to the custom deleter. Here's the fun part. From
> https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes:
> "If you rely on symbols from bar.h, don't count on the fact that you included
> foo.h which (currently) includes bar.h: include bar.h yourself, unless foo.h
> explicitly demonstrates its intent to provide you the symbols of bar.h."
> 
> Does interface.h demonstrate an intent to specifically expose headers like
> <memory> to us? I feel like you could argue either way on this one.

The algorithm I used in my head is to look where the first definition of the
type comes from. Here it's local to this file so I expect an include. The return
type of the function comes from the header, so I don't for that one.

[danakj, 2016-04-22 23:15:38]

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/alsa_o...
File media/audio/alsa/alsa_output.cc (right):

https://codereview.chromium.org/1911913002/diff/20001/media/audio/alsa/alsa_o...
media/audio/alsa/alsa_output.cc:564: std::unique_ptr<char, base::FreeDeleter>
io(
On 2016/04/22 23:13:19, dcheng wrote:
> On 2016/04/22 at 22:47:35, danakj wrote:
> > include memory
> 
> I shall invoke the style guide here:
> "However, any includes present in the related header do not need to be
included
> again in the related cc (i.e., foo.cc can rely on foo.h's includes)."

Oh okay I can adjust my algorithm then.

[dcheng, 2016-04-22 23:38:46]

OK, adjusted cast_audio_manager_factory.cc as well.

[danakj, 2016-04-23 00:11:28]

LGTM

[danakj, 2016-04-23 00:11:40]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-23 00:11:40]

The patchset sent to the CQ was uploaded after l-g-t-m from miu@chromium.org
Link to the patchset: https://codereview.chromium.org/1911913002/#ps80001
(title: ".")

[commit-bot: I haz the power, 2016-04-23 00:12:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911913002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911913002/80001

[commit-bot: I haz the power, 2016-04-23 02:36:20]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-23 02:37:43]

Description was changed from

==========
Convert //media/audio from scoped_ptr to std::unique_ptr

BUG=554298
R=danakj@chromium.org
TBR=brettw@chromium.org
==========

to

==========
Convert //media/audio from scoped_ptr to std::unique_ptr

BUG=554298
R=danakj@chromium.org
TBR=brettw@chromium.org

Committed: https://crrev.com/7089de047f9845b19afd5b671ace13aa1aa3ad42
Cr-Commit-Position: refs/heads/master@{#389347}
==========

[commit-bot: I haz the power, 2016-04-23 02:37:44]

Patchset 5 (id:??) landed as
https://crrev.com/7089de047f9845b19afd5b671ace13aa1aa3ad42
Cr-Commit-Position: refs/heads/master@{#389347}