Replace scoped_ptr with std::unique_ptr in //media/base.

Replace scoped_ptr with std::unique_ptr in //media/base.

Plus some other bonus ones in media and some IWYU fixes.

TBR=brettw, dalecurtis
BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/6aaed6a40bc23a872e14f19a39ff2d7998c803d0
Cr-Commit-Position: refs/heads/master@{#389652}

[danakj, 2016-04-23 00:33:30]

danakj@chromium.org changed reviewers:
+ dcheng@chromium.org

[danakj, 2016-04-23 00:33:31]

Did a pass-over with a bunch of IWYU fixes in media/

[danakj, 2016-04-23 00:38:20]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-23 00:38:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906423005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906423005/40001

[danakj, 2016-04-23 00:48:24]

Description was changed from

==========
Replace scoped_ptr with std::unique_ptr in //media/base.

Plus some other bonus ones in media and some IWYU fixes.

R=brettw, dalecurtis
BUG=554298
==========

to

==========
Replace scoped_ptr with std::unique_ptr in //media/base.

Plus some other bonus ones in media and some IWYU fixes.

TBR=brettw, dalecurtis
BUG=554298
==========

[danakj, 2016-04-23 00:50:39]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-23 00:51:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906423005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906423005/60001

[dcheng, 2016-04-23 00:57:23]

LGTM with optional nits.

https://codereview.chromium.org/1906423005/diff/40001/media/base/audio_render...
File media/base/audio_renderer_mixer.h (right):

https://codereview.chromium.org/1906423005/diff/40001/media/base/audio_render...
media/base/audio_renderer_mixer.h:53: typedef std::map<int,
std::unique_ptr<LoopbackAudioConverter>>
using if you want.

https://codereview.chromium.org/1906423005/diff/40001/media/base/demuxer.h
File media/base/demuxer.h (right):

https://codereview.chromium.org/1906423005/diff/40001/media/base/demuxer.h#ne...
media/base/demuxer.h:72: typedef
base::Callback<void(std::unique_ptr<MediaTracks>)>
using if you're bored

https://codereview.chromium.org/1906423005/diff/40001/media/base/media_tracks.h
File media/base/media_tracks.h (right):

https://codereview.chromium.org/1906423005/diff/40001/media/base/media_tracks...
media/base/media_tracks.h:24: typedef std::vector<std::unique_ptr<MediaTrack>>
MediaTracksCollection;
using? =D

https://codereview.chromium.org/1906423005/diff/40001/media/base/stream_parser.h
File media/base/stream_parser.h (right):

https://codereview.chromium.org/1906423005/diff/40001/media/base/stream_parse...
media/base/stream_parser.h:92: typedef
base::Callback<bool(std::unique_ptr<MediaTracks>,
using if you're feeling so inclined

https://codereview.chromium.org/1906423005/diff/40001/media/base/text_track.h
File media/base/text_track.h (right):

https://codereview.chromium.org/1906423005/diff/40001/media/base/text_track.h...
media/base/text_track.h:28: typedef
base::Callback<void(std::unique_ptr<TextTrack>)> AddTextTrackDoneCB;
using, possibly

https://codereview.chromium.org/1906423005/diff/40001/media/base/video_frame.h
File media/base/video_frame.h (right):

https://codereview.chromium.org/1906423005/diff/40001/media/base/video_frame....
media/base/video_frame.h:532: // refactoring VideoFrame, change to
std::unique_ptr<uint8_t,
This wrapping is kind of unfortunate. Maybe we can reorder this sentence "change
to std::unique_ptr<...> after refactoring VideoFrame." for it to be less
awkward.

[commit-bot: I haz the power, 2016-04-23 01:10:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-23 01:10:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[danakj, 2016-04-23 01:11:15]

Plus some bonus other usings too.

https://codereview.chromium.org/1906423005/diff/40001/media/base/audio_render...
File media/base/audio_renderer_mixer.h (right):

https://codereview.chromium.org/1906423005/diff/40001/media/base/audio_render...
media/base/audio_renderer_mixer.h:53: typedef std::map<int,
std::unique_ptr<LoopbackAudioConverter>>
On 2016/04/23 00:57:23, dcheng wrote:
> using if you want.

Done.

https://codereview.chromium.org/1906423005/diff/40001/media/base/demuxer.h
File media/base/demuxer.h (right):

https://codereview.chromium.org/1906423005/diff/40001/media/base/demuxer.h#ne...
media/base/demuxer.h:72: typedef
base::Callback<void(std::unique_ptr<MediaTracks>)>
On 2016/04/23 00:57:23, dcheng wrote:
> using if you're bored

Done.

https://codereview.chromium.org/1906423005/diff/40001/media/base/media_tracks.h
File media/base/media_tracks.h (right):

https://codereview.chromium.org/1906423005/diff/40001/media/base/media_tracks...
media/base/media_tracks.h:24: typedef std::vector<std::unique_ptr<MediaTrack>>
MediaTracksCollection;
On 2016/04/23 00:57:23, dcheng wrote:
> using? =D

Done.

https://codereview.chromium.org/1906423005/diff/40001/media/base/stream_parser.h
File media/base/stream_parser.h (right):

https://codereview.chromium.org/1906423005/diff/40001/media/base/stream_parse...
media/base/stream_parser.h:92: typedef
base::Callback<bool(std::unique_ptr<MediaTracks>,
On 2016/04/23 00:57:23, dcheng wrote:
> using if you're feeling so inclined

Done.

https://codereview.chromium.org/1906423005/diff/40001/media/base/text_track.h
File media/base/text_track.h (right):

https://codereview.chromium.org/1906423005/diff/40001/media/base/text_track.h...
media/base/text_track.h:28: typedef
base::Callback<void(std::unique_ptr<TextTrack>)> AddTextTrackDoneCB;
On 2016/04/23 00:57:23, dcheng wrote:
> using, possibly

Done.

https://codereview.chromium.org/1906423005/diff/40001/media/base/video_frame.h
File media/base/video_frame.h (right):

https://codereview.chromium.org/1906423005/diff/40001/media/base/video_frame....
media/base/video_frame.h:532: // refactoring VideoFrame, change to
std::unique_ptr<uint8_t,
On 2016/04/23 00:57:23, dcheng wrote:
> This wrapping is kind of unfortunate. Maybe we can reorder this sentence
"change
> to std::unique_ptr<...> after refactoring VideoFrame." for it to be less
> awkward.

Done.

[danakj, 2016-04-23 01:11:27]

TBR=brettw

[danakj, 2016-04-23 01:11:59]

Description was changed from

==========
Replace scoped_ptr with std::unique_ptr in //media/base.

Plus some other bonus ones in media and some IWYU fixes.

TBR=brettw, dalecurtis
BUG=554298
==========

to

==========
Replace scoped_ptr with std::unique_ptr in //media/base.

Plus some other bonus ones in media and some IWYU fixes.

TBR=brettw, dalecurtis
BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[DaleCurtis, 2016-04-23 19:01:36]

lgtm

[danakj, 2016-04-25 20:33:08]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-25 20:33:09]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1906423005/#ps80001
(title: "scopedptr-media-base: usings")

[commit-bot: I haz the power, 2016-04-25 20:34:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906423005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906423005/80001

[commit-bot: I haz the power, 2016-04-25 21:16:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 21:16:08]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[danakj, 2016-04-25 21:33:00]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-25 21:33:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1906423005/#ps100001
(title: "scopedptr-media-base: android")

[commit-bot: I haz the power, 2016-04-25 21:34:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906423005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906423005/100001

[commit-bot: I haz the power, 2016-04-26 01:25:58]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-26 01:27:15]

Description was changed from

==========
Replace scoped_ptr with std::unique_ptr in //media/base.

Plus some other bonus ones in media and some IWYU fixes.

TBR=brettw, dalecurtis
BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Replace scoped_ptr with std::unique_ptr in //media/base.

Plus some other bonus ones in media and some IWYU fixes.

TBR=brettw, dalecurtis
BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/6aaed6a40bc23a872e14f19a39ff2d7998c803d0
Cr-Commit-Position: refs/heads/master@{#389652}
==========

[commit-bot: I haz the power, 2016-04-26 01:27:17]

Patchset 6 (id:??) landed as
https://crrev.com/6aaed6a40bc23a872e14f19a39ff2d7998c803d0
Cr-Commit-Position: refs/heads/master@{#389652}