Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1909773002: Convert //extensions/browser from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //extensions/browser from scoped_ptr to std::unique_ptr BUG=554298 R=rockot@chromium.org Committed: https://crrev.com/f5d2410841791e8c32739a4418159489e1dde324 Cr-Commit-Position: refs/heads/master@{#388687}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+892 lines, -824 lines) Patch
M extensions/browser/api_activity_monitor.h View 2 chunks +6 lines, -5 lines 0 comments Download
M extensions/browser/api_test_utils.h View 5 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api_test_utils.cc View 10 chunks +25 lines, -22 lines 0 comments Download
M extensions/browser/api_unittest.h View 3 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/api_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/app_window/app_window.h View 4 chunks +9 lines, -8 lines 0 comments Download
M extensions/browser/app_window/app_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/app_window/app_window_contents.h View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/app_window/app_window_geometry_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/app_window/app_window_geometry_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/app_window/app_window_geometry_cache_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/app_window/native_app_window.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/app_window/test_app_window_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/blob_holder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/blob_holder.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/computed_hashes.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/computed_hashes.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/content_hash_fetcher.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/content_hash_reader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/content_hash_tree.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/content_hash_tree_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/content_verifier.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/content_verifier.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/content_verifier_io_data.h View 2 chunks +5 lines, -4 lines 0 comments Download
M extensions/browser/content_verifier_io_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/content_verify_job.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/declarative_user_script_master.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/error_map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/error_map.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/error_map_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/event_listener_map.h View 5 chunks +10 lines, -10 lines 0 comments Download
M extensions/browser/event_listener_map.cc View 8 chunks +23 lines, -21 lines 0 comments Download
M extensions/browser/event_listener_map_unittest.cc View 18 chunks +61 lines, -55 lines 0 comments Download
M extensions/browser/event_router.h View 1 2 4 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/event_router.cc View 15 chunks +31 lines, -36 lines 0 comments Download
M extensions/browser/event_router_unittest.cc View 6 chunks +16 lines, -14 lines 0 comments Download
M extensions/browser/extension_error_test_util.h View 2 chunks +6 lines, -5 lines 0 comments Download
M extensions/browser/extension_error_test_util.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M extensions/browser/extension_function.h View 8 chunks +13 lines, -12 lines 0 comments Download
M extensions/browser/extension_function.cc View 7 chunks +12 lines, -10 lines 0 comments Download
M extensions/browser/extension_function_dispatcher.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/extension_host.h View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/extension_icon_image_unittest.cc View 4 chunks +10 lines, -17 lines 0 comments Download
M extensions/browser/extension_message_filter.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/extension_pref_value_map.h View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/extension_pref_value_map.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/extension_pref_value_map_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M extensions/browser/extension_prefs.h View 11 chunks +14 lines, -14 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 22 chunks +38 lines, -35 lines 0 comments Download
M extensions/browser/extension_prefs_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/extension_prefs_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_protocols.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_protocols.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/extension_registry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_registry.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/browser/extension_system.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_throttle_entry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_throttle_manager.h View 4 chunks +5 lines, -4 lines 0 comments Download
M extensions/browser/extension_throttle_manager.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/extension_throttle_simulation_unittest.cc View 7 chunks +8 lines, -7 lines 0 comments Download
M extensions/browser/extension_throttle_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/extension_user_script_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_user_script_loader.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/extension_zoom_request_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/extensions_browser_client.h View 5 chunks +8 lines, -7 lines 0 comments Download
M extensions/browser/extensions_browser_client.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/browser/extensions_test.h View 2 chunks +7 lines, -6 lines 0 comments Download
M extensions/browser/external_install_info.h View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/external_install_info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/external_provider_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/app_view/app_view_guest.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/guest_view/app_view/app_view_guest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M extensions/browser/guest_view/extension_view/extension_view_guest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/extensions_guest_view_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.h View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_find_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_find_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 15 chunks +35 lines, -34 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_permission_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_permission_helper.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M extensions/browser/image_loader_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/info_map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/lazy_background_task_queue_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M extensions/browser/load_monitoring_extension_host_queue.h View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/load_monitoring_extension_host_queue.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/load_monitoring_extension_host_queue_unittest.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M extensions/browser/mock_extension_system.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/mock_extension_system.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/mojo/keep_alive_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/mojo/stash_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/mojo/stash_backend.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/mojo/stash_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/process_manager_unittest.cc View 8 chunks +11 lines, -12 lines 0 comments Download
M extensions/browser/quota_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/quota_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/sandboxed_unpacker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/sandboxed_unpacker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/state_store.h View 3 chunks +5 lines, -4 lines 0 comments Download
M extensions/browser/state_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/test_extension_registry_observer.h View 2 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/test_extension_registry_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/test_extensions_browser_client.h View 4 chunks +8 lines, -7 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/updater/extension_downloader.h View 1 2 9 chunks +18 lines, -15 lines 0 comments Download
M extensions/browser/updater/extension_downloader.cc View 1 2 9 chunks +9 lines, -9 lines 0 comments Download
M extensions/browser/updater/request_queue.h View 4 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/updater/request_queue_impl.h View 1 chunk +6 lines, -5 lines 0 comments Download
M extensions/browser/updater/safe_manifest_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/updater/update_service.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/updater/update_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/user_script_loader.h View 6 chunks +9 lines, -9 lines 0 comments Download
M extensions/browser/user_script_loader.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M extensions/browser/value_store/lazy_leveldb.h View 4 chunks +6 lines, -5 lines 0 comments Download
M extensions/browser/value_store/lazy_leveldb.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M extensions/browser/value_store/legacy_value_store_factory.h View 3 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/value_store/legacy_value_store_factory.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M extensions/browser/value_store/leveldb_scoped_database.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/value_store/leveldb_scoped_database.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M extensions/browser/value_store/leveldb_scoped_database_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/value_store/leveldb_value_store.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/value_store/leveldb_value_store.cc View 8 chunks +12 lines, -12 lines 0 comments Download
M extensions/browser/value_store/leveldb_value_store_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/value_store/test_value_store_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/value_store/test_value_store_factory.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M extensions/browser/value_store/testing_value_store.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M extensions/browser/value_store/value_store.h View 6 chunks +13 lines, -11 lines 0 comments Download
M extensions/browser/value_store/value_store.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/value_store/value_store_change.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/value_store/value_store_change_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/value_store/value_store_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/value_store/value_store_factory_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/value_store/value_store_factory_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/value_store/value_store_frontend.h View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/value_store/value_store_frontend.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/value_store/value_store_frontend_unittest.cc View 5 chunks +11 lines, -9 lines 0 comments Download
M extensions/browser/value_store/value_store_unittest.h View 3 chunks +11 lines, -10 lines 0 comments Download
M extensions/browser/verified_contents.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/web_ui_user_script_loader.h View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/web_ui_user_script_loader.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.h View 1 4 chunks +10 lines, -7 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 1 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
dcheng
This is largely a search and replace. There's probably some IWYU errors (files that don't ...
4 years, 8 months ago (2016-04-21 00:56:08 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 8 months ago (2016-04-21 01:17:08 UTC) #3
dcheng
PTAL at the build fixes in //extensions/shell.
4 years, 8 months ago (2016-04-21 01:59:07 UTC) #4
Ken Rockot(use gerrit already)
Still lgtm
4 years, 8 months ago (2016-04-21 02:04:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909773002/20001
4 years, 8 months ago (2016-04-21 02:07:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/54100) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-21 02:11:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909773002/40001
4 years, 8 months ago (2016-04-21 02:45:56 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-21 03:43:22 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:31:20 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f5d2410841791e8c32739a4418159489e1dde324
Cr-Commit-Position: refs/heads/master@{#388687}

Powered by Google App Engine
This is Rietveld 408576698