extensions/browser/guest_view/extension_view/extension_view_guest.cc - Issue 1909773002: Convert //extensions/browser from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extension_view/extension_view_guest.cc

Issue 1909773002: Convert //extensions/browser from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/extension_options/extension_options_guest.cc ('k') | extensions/browser/guest_view/extensions_guest_view_manager_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extension_view/extension_view_guest.cc

diff --git a/extensions/browser/guest_view/extension_view/extension_view_guest.cc b/extensions/browser/guest_view/extension_view/extension_view_guest.cc

index 0c961df1f19f7401a223e222709d0e874a1749f2..73cfc9d725644a6ad2e6931cf69fd6a022948951 100644

--- a/extensions/browser/guest_view/extension_view/extension_view_guest.cc

+++ b/extensions/browser/guest_view/extension_view/extension_view_guest.cc

@@ -6,6 +6,7 @@

#include <utility>

+#include "base/memory/ptr_util.h"

#include "components/crx_file/id_util.h"

#include "components/guest_view/browser/guest_view_event.h"

#include "content/public/browser/render_process_host.h"

@@ -125,9 +126,9 @@ void ExtensionViewGuest::DidCommitProvisionalLoadForFrame(

url_ = url;

- scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());

+ std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());

args->SetString(guest_view::kUrl, url_.spec());

- DispatchEventToView(make_scoped_ptr(

+ DispatchEventToView(base::WrapUnique(

new GuestViewEvent(extensionview::kEventLoadCommit, std::move(args))));

}