extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.cc - Issue 1909773002: Convert //extensions/browser from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.cc

Issue 1909773002: Convert //extensions/browser from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.h ('k') | extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.cc

diff --git a/extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.cc b/extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.cc

index ce68bdb589fe9d549331f58096c8f787c88f0963..d15d1c038c0ab3d44176c0e5ed52e53ba4ebf870 100644

--- a/extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.cc

+++ b/extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.cc

@@ -43,7 +43,7 @@ void TestMimeHandlerViewGuest::CreateWebContents(

if (delay_) {

auto delta = base::TimeDelta::FromMilliseconds(

delay_);

- scoped_ptr<base::DictionaryValue> params(create_params.DeepCopy());

+ std::unique_ptr<base::DictionaryValue> params(create_params.DeepCopy());

content::BrowserThread::PostDelayedTask(

content::BrowserThread::UI,

FROM_HERE,

@@ -68,7 +68,7 @@ void TestMimeHandlerViewGuest::DidAttachToEmbedder() {

}

void TestMimeHandlerViewGuest::CallBaseCreateWebContents(

- scoped_ptr<base::DictionaryValue> create_params,

+ std::unique_ptr<base::DictionaryValue> create_params,

const WebContentsCreatedCallback& callback) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

MimeHandlerViewGuest::CreateWebContents(*create_params.get(), callback);