extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc - Issue 1909773002: Convert //extensions/browser from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc

Issue 1909773002: Convert //extensions/browser from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/extensions_guest_view_manager_delegate.h ('k') | extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc

diff --git a/extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc b/extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc

index f7d5923a092432d8ab9aa538f37866f314197f2a..8c73d37391da5e247d7113eaa0385b1f68c448bc 100644

--- a/extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc

+++ b/extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc

@@ -39,12 +39,12 @@ ExtensionsGuestViewManagerDelegate::~ExtensionsGuestViewManagerDelegate() {

void ExtensionsGuestViewManagerDelegate::DispatchEvent(

const std::string& event_name,

- scoped_ptr<base::DictionaryValue> args,

+ std::unique_ptr<base::DictionaryValue> args,

GuestViewBase* guest,

int instance_id) {

EventFilteringInfo info;

info.SetInstanceID(instance_id);

- scoped_ptr<base::ListValue> event_args(new base::ListValue());

+ std::unique_ptr<base::ListValue> event_args(new base::ListValue());

event_args->Append(args.release());

// GetEventHistogramValue maps guest view event names to their histogram