extensions/browser/guest_view/web_view/web_view_guest.h - Issue 1909773002: Convert //extensions/browser from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 1909773002: Convert //extensions/browser from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_find_helper.cc ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_guest.h

diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h

index 19391ac966eb166011a8fe1df29fd5df3036092b..88d0f103d3c70b174c376c4ea2c5c3eb00b8d1eb 100644

--- a/extensions/browser/guest_view/web_view/web_view_guest.h

+++ b/extensions/browser/guest_view/web_view/web_view_guest.h

@@ -328,7 +328,7 @@ class WebViewGuest : public guest_view::GuestView<WebViewGuest>,

WebViewFindHelper find_helper_;

base::ObserverList<ScriptExecutionObserver> script_observers_;

- scoped_ptr<ScriptExecutor> script_executor_;

+ std::unique_ptr<ScriptExecutor> script_executor_;

content::NotificationRegistrar notification_registrar_;

@@ -348,9 +348,9 @@ class WebViewGuest : public guest_view::GuestView<WebViewGuest>,

JavaScriptDialogHelper javascript_dialog_helper_;

// Handles permission requests.

- scoped_ptr<WebViewPermissionHelper> web_view_permission_helper_;

+ std::unique_ptr<WebViewPermissionHelper> web_view_permission_helper_;

- scoped_ptr<WebViewGuestDelegate> web_view_guest_delegate_;

+ std::unique_ptr<WebViewGuestDelegate> web_view_guest_delegate_;

// Tracks the name, and target URL of the new window. Once the first

// navigation commits, we no longer track this information.