Spec-compliant parsing and initial values for 'orphans' and 'widows'.

Spec-compliant parsing and initial values for 'orphans' and 'widows'.

The initial values for these properties should be '2', not 'auto'. 'auto' isn't
even an allowed value in the spec. So remove support for that completely.

FWIW: 'auto' used to mean pretty much the same as '1'.

Quite a few tests have to be updated because of this change, typically because
they assume that there are no orphans and widows requirements, meaning that
there'd be no breaking restrictions between lines. In those cases, now that the
initial value is '2', we need to set 'orphans' and 'widows' to '1' explicitly
if we don't want any restrictions. There are also some non-layout tests that
expect the initial value to be 'auto' or '1'. In those cases we need to just
update the expectations to be '2' instead.

BUG=473509
Committed: https://crrev.com/b25fd3116d7cb9366a24af711666fc63a27f91b4
Cr-Commit-Position: refs/heads/master@{#389061}

[mstensho (USE GERRIT), 2016-04-21 21:48:28]

mstensho@opera.com changed reviewers:
+ eae@chromium.org, leviw@chromium.org, szager@chromium.org,
wkorman@chromium.org

[mstensho (USE GERRIT), 2016-04-21 21:48:30]

Although this has been correctly implemented in IE/Edge (and Presto, FWIW) for
ages, there's a theoretical site-compat risk here.

Do I need to run this through the intents / dashboard systems first?

https://codereview.chromium.org/1909233002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp (right):

https://codereview.chromium.org/1909233002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:981: if (paginated
&& style()->widows() > 1 && !didBreakAtLineToAvoidWidow()) {
The widows > 1 check here is new, but there's really no need to perform this
step if widows is 1.

[eae, 2016-04-21 22:04:26]

LGTM

Thanks! That's quite a few tests.

[eae, 2016-04-21 22:04:59]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-04-21 22:05:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909233002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909233002/1

[commit-bot: I haz the power, 2016-04-21 22:44:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 22:44:09]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[mstensho (USE GERRIT), 2016-04-22 07:53:17]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-04-22 07:53:17]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1909233002/#ps20001
(title: "Some unit tests had non-conformant widphans assumptions too.")

[commit-bot: I haz the power, 2016-04-22 07:53:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909233002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909233002/20001

[commit-bot: I haz the power, 2016-04-22 09:18:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:45:41]

Description was changed from

==========
Spec-compliant parsing and initial values for 'orphans' and 'widows'.

The initial values for these properties should be '2', not 'auto'. 'auto' isn't
even an allowed value in the spec. So remove support for that completely.

FWIW: 'auto' used to mean pretty much the same as '1'.

Quite a few tests have to be updated because of this change, typically because
they assume that there are no orphans and widows requirements, meaning that
there'd be no breaking restrictions between lines. In those cases, now that the
initial value is '2', we need to set 'orphans' and 'widows' to '1' explicitly
if we don't want any restrictions. There are also some non-layout tests that
expect the initial value to be 'auto' or '1'. In those cases we need to just
update the expectations to be '2' instead.

BUG=473509
==========

to

==========
Spec-compliant parsing and initial values for 'orphans' and 'widows'.

The initial values for these properties should be '2', not 'auto'. 'auto' isn't
even an allowed value in the spec. So remove support for that completely.

FWIW: 'auto' used to mean pretty much the same as '1'.

Quite a few tests have to be updated because of this change, typically because
they assume that there are no orphans and widows requirements, meaning that
there'd be no breaking restrictions between lines. In those cases, now that the
initial value is '2', we need to set 'orphans' and 'widows' to '1' explicitly
if we don't want any restrictions. There are also some non-layout tests that
expect the initial value to be 'auto' or '1'. In those cases we need to just
update the expectations to be '2' instead.

BUG=473509

Committed: https://crrev.com/b25fd3116d7cb9366a24af711666fc63a27f91b4
Cr-Commit-Position: refs/heads/master@{#389061}
==========

[commit-bot: I haz the power, 2016-04-22 19:45:42]

Patchset 2 (id:??) landed as
https://crrev.com/b25fd3116d7cb9366a24af711666fc63a27f91b4
Cr-Commit-Position: refs/heads/master@{#389061}