third_party/WebKit/Source/core/layout/ColumnBalancer.cpp - Issue 1909233002: Spec-compliant parsing and initial values for 'orphans' and 'widows'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ColumnBalancer.cpp

Issue 1909233002: Spec-compliant parsing and initial values for 'orphans' and 'widows'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Some unit tests had non-conformant widphans assumptions too. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ColumnBalancer.cpp

diff --git a/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp b/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp

index 1ba071994ee615703c926bdedf4bb874cca748d3..c6ebd999f64186e7ae9cd2c633b045cb1912113f 100644

--- a/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp

+++ b/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp

@@ -139,7 +139,7 @@ static inline LayoutUnit columnLogicalHeightRequirementForLine(const ComputedSty

{

// We may require a certain minimum number of lines per page in order to satisfy

// orphans and widows, and that may affect the minimum page height.

- unsigned minimumLineCount = std::max<unsigned>(style.hasAutoOrphans() ? 1 : style.orphans(), style.widows());

+ unsigned minimumLineCount = std::max<unsigned>(style.orphans(), style.widows());

const RootInlineBox* firstLine = &lastLine;

for (unsigned i = 1; i < minimumLineCount && firstLine->prevRootBox(); i++)

firstLine = firstLine->prevRootBox();