Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp

Issue 1909233002: Spec-compliant parsing and initial values for 'orphans' and 'widows'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Some unit tests had non-conformant widphans assumptions too. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/StyleRareInheritedData.h ('k') | third_party/WebKit/Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org) 2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 56
57 static_assert(sizeof(StyleRareInheritedData) <= sizeof(SameSizeAsStyleRareInheri tedData), "StyleRareInheritedData should stay small"); 57 static_assert(sizeof(StyleRareInheritedData) <= sizeof(SameSizeAsStyleRareInheri tedData), "StyleRareInheritedData should stay small");
58 58
59 StyleRareInheritedData::StyleRareInheritedData() 59 StyleRareInheritedData::StyleRareInheritedData()
60 : listStyleImage(ComputedStyle::initialListStyleImage()) 60 : listStyleImage(ComputedStyle::initialListStyleImage())
61 , textStrokeWidth(ComputedStyle::initialTextStrokeWidth()) 61 , textStrokeWidth(ComputedStyle::initialTextStrokeWidth())
62 , indent(ComputedStyle::initialTextIndent()) 62 , indent(ComputedStyle::initialTextIndent())
63 , m_effectiveZoom(ComputedStyle::initialZoom()) 63 , m_effectiveZoom(ComputedStyle::initialZoom())
64 , widows(ComputedStyle::initialWidows()) 64 , widows(ComputedStyle::initialWidows())
65 , orphans(ComputedStyle::initialOrphans()) 65 , orphans(ComputedStyle::initialOrphans())
66 , m_hasAutoOrphans(true)
67 , m_textStrokeColorIsCurrentColor(true) 66 , m_textStrokeColorIsCurrentColor(true)
68 , m_textFillColorIsCurrentColor(true) 67 , m_textFillColorIsCurrentColor(true)
69 , m_textEmphasisColorIsCurrentColor(true) 68 , m_textEmphasisColorIsCurrentColor(true)
70 , m_visitedLinkTextStrokeColorIsCurrentColor(true) 69 , m_visitedLinkTextStrokeColorIsCurrentColor(true)
71 , m_visitedLinkTextFillColorIsCurrentColor(true) 70 , m_visitedLinkTextFillColorIsCurrentColor(true)
72 , m_visitedLinkTextEmphasisColorIsCurrentColor(true) 71 , m_visitedLinkTextEmphasisColorIsCurrentColor(true)
73 , textSecurity(ComputedStyle::initialTextSecurity()) 72 , textSecurity(ComputedStyle::initialTextSecurity())
74 , userModify(READ_ONLY) 73 , userModify(READ_ONLY)
75 , wordBreak(ComputedStyle::initialWordBreak()) 74 , wordBreak(ComputedStyle::initialWordBreak())
76 , overflowWrap(ComputedStyle::initialOverflowWrap()) 75 , overflowWrap(ComputedStyle::initialOverflowWrap())
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 , m_visitedLinkTextStrokeColor(o.m_visitedLinkTextStrokeColor) 112 , m_visitedLinkTextStrokeColor(o.m_visitedLinkTextStrokeColor)
114 , m_visitedLinkTextFillColor(o.m_visitedLinkTextFillColor) 113 , m_visitedLinkTextFillColor(o.m_visitedLinkTextFillColor)
115 , m_visitedLinkTextEmphasisColor(o.m_visitedLinkTextEmphasisColor) 114 , m_visitedLinkTextEmphasisColor(o.m_visitedLinkTextEmphasisColor)
116 , textShadow(o.textShadow) 115 , textShadow(o.textShadow)
117 , highlight(o.highlight) 116 , highlight(o.highlight)
118 , cursorData(o.cursorData) 117 , cursorData(o.cursorData)
119 , indent(o.indent) 118 , indent(o.indent)
120 , m_effectiveZoom(o.m_effectiveZoom) 119 , m_effectiveZoom(o.m_effectiveZoom)
121 , widows(o.widows) 120 , widows(o.widows)
122 , orphans(o.orphans) 121 , orphans(o.orphans)
123 , m_hasAutoOrphans(o.m_hasAutoOrphans)
124 , m_textStrokeColorIsCurrentColor(o.m_textStrokeColorIsCurrentColor) 122 , m_textStrokeColorIsCurrentColor(o.m_textStrokeColorIsCurrentColor)
125 , m_textFillColorIsCurrentColor(o.m_textFillColorIsCurrentColor) 123 , m_textFillColorIsCurrentColor(o.m_textFillColorIsCurrentColor)
126 , m_textEmphasisColorIsCurrentColor(o.m_textEmphasisColorIsCurrentColor) 124 , m_textEmphasisColorIsCurrentColor(o.m_textEmphasisColorIsCurrentColor)
127 , m_visitedLinkTextStrokeColorIsCurrentColor(o.m_visitedLinkTextStrokeColorI sCurrentColor) 125 , m_visitedLinkTextStrokeColorIsCurrentColor(o.m_visitedLinkTextStrokeColorI sCurrentColor)
128 , m_visitedLinkTextFillColorIsCurrentColor(o.m_visitedLinkTextFillColorIsCur rentColor) 126 , m_visitedLinkTextFillColorIsCurrentColor(o.m_visitedLinkTextFillColorIsCur rentColor)
129 , m_visitedLinkTextEmphasisColorIsCurrentColor(o.m_visitedLinkTextEmphasisCo lorIsCurrentColor) 127 , m_visitedLinkTextEmphasisColorIsCurrentColor(o.m_visitedLinkTextEmphasisCo lorIsCurrentColor)
130 , textSecurity(o.textSecurity) 128 , textSecurity(o.textSecurity)
131 , userModify(o.userModify) 129 , userModify(o.userModify)
132 , wordBreak(o.wordBreak) 130 , wordBreak(o.wordBreak)
133 , overflowWrap(o.overflowWrap) 131 , overflowWrap(o.overflowWrap)
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 && m_visitedLinkTextFillColor == o.m_visitedLinkTextFillColor 176 && m_visitedLinkTextFillColor == o.m_visitedLinkTextFillColor
179 && m_visitedLinkTextEmphasisColor == o.m_visitedLinkTextEmphasisColor 177 && m_visitedLinkTextEmphasisColor == o.m_visitedLinkTextEmphasisColor
180 && tapHighlightColor == o.tapHighlightColor 178 && tapHighlightColor == o.tapHighlightColor
181 && shadowDataEquivalent(o) 179 && shadowDataEquivalent(o)
182 && highlight == o.highlight 180 && highlight == o.highlight
183 && dataEquivalent(cursorData.get(), o.cursorData.get()) 181 && dataEquivalent(cursorData.get(), o.cursorData.get())
184 && indent == o.indent 182 && indent == o.indent
185 && m_effectiveZoom == o.m_effectiveZoom 183 && m_effectiveZoom == o.m_effectiveZoom
186 && widows == o.widows 184 && widows == o.widows
187 && orphans == o.orphans 185 && orphans == o.orphans
188 && m_hasAutoOrphans == o.m_hasAutoOrphans
189 && m_textStrokeColorIsCurrentColor == o.m_textStrokeColorIsCurrentColor 186 && m_textStrokeColorIsCurrentColor == o.m_textStrokeColorIsCurrentColor
190 && m_textFillColorIsCurrentColor == o.m_textFillColorIsCurrentColor 187 && m_textFillColorIsCurrentColor == o.m_textFillColorIsCurrentColor
191 && m_textEmphasisColorIsCurrentColor == o.m_textEmphasisColorIsCurrentCo lor 188 && m_textEmphasisColorIsCurrentColor == o.m_textEmphasisColorIsCurrentCo lor
192 && m_visitedLinkTextStrokeColorIsCurrentColor == o.m_visitedLinkTextStro keColorIsCurrentColor 189 && m_visitedLinkTextStrokeColorIsCurrentColor == o.m_visitedLinkTextStro keColorIsCurrentColor
193 && m_visitedLinkTextFillColorIsCurrentColor == o.m_visitedLinkTextFillCo lorIsCurrentColor 190 && m_visitedLinkTextFillColorIsCurrentColor == o.m_visitedLinkTextFillCo lorIsCurrentColor
194 && m_visitedLinkTextEmphasisColorIsCurrentColor == o.m_visitedLinkTextEm phasisColorIsCurrentColor 191 && m_visitedLinkTextEmphasisColorIsCurrentColor == o.m_visitedLinkTextEm phasisColorIsCurrentColor
195 && textSecurity == o.textSecurity 192 && textSecurity == o.textSecurity
196 && userModify == o.userModify 193 && userModify == o.userModify
197 && wordBreak == o.wordBreak 194 && wordBreak == o.wordBreak
198 && overflowWrap == o.overflowWrap 195 && overflowWrap == o.overflowWrap
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 { 230 {
234 return dataEquivalent(textShadow.get(), o.textShadow.get()); 231 return dataEquivalent(textShadow.get(), o.textShadow.get());
235 } 232 }
236 233
237 bool StyleRareInheritedData::quotesDataEquivalent(const StyleRareInheritedData& o) const 234 bool StyleRareInheritedData::quotesDataEquivalent(const StyleRareInheritedData& o) const
238 { 235 {
239 return dataEquivalent(quotes, o.quotes); 236 return dataEquivalent(quotes, o.quotes);
240 } 237 }
241 238
242 } // namespace blink 239 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/style/StyleRareInheritedData.h ('k') | third_party/WebKit/Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698