Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 1909233002: Spec-compliant parsing and initial values for 'orphans' and 'widows'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Some unit tests had non-conformant widphans assumptions too. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
index cf7095038d1d273068007209f0fe23ba98046f6c..1d2c858f829b23c285d0cc013777a8dd69ee9f68 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
@@ -1224,14 +1224,6 @@ bool CSSPropertyParser::consumeAnimationShorthand(const StylePropertyShorthand&
return m_range.atEnd();
}
-static CSSValue* consumeWidowsOrOrphans(CSSParserTokenRange& range)
-{
- // Support for auto is non-standard and for backwards compatibility.
- if (range.peek().id() == CSSValueAuto)
- return consumeIdent(range);
- return consumePositiveInteger(range);
-}
-
static CSSValue* consumeZIndex(CSSParserTokenRange& range)
{
if (range.peek().id() == CSSValueAuto)
@@ -3574,10 +3566,9 @@ CSSValue* CSSPropertyParser::parseSingleValue(CSSPropertyID unresolvedProperty)
case CSSPropertyShapeImageThreshold:
return consumeNumber(m_range, ValueRangeAll);
case CSSPropertyWebkitBoxOrdinalGroup:
- return consumePositiveInteger(m_range);
case CSSPropertyOrphans:
case CSSPropertyWidows:
- return consumeWidowsOrOrphans(m_range);
+ return consumePositiveInteger(m_range);
case CSSPropertyTextDecorationColor:
ASSERT(RuntimeEnabledFeatures::css3TextDecorationsEnabled());
return consumeColor(m_range, m_context.mode());

Powered by Google App Engine
This is Rietveld 408576698