third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp - Issue 1909233002: Spec-compliant parsing and initial values for 'orphans' and 'widows'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp

Issue 1909233002: Spec-compliant parsing and initial values for 'orphans' and 'widows'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Some unit tests had non-conformant widphans assumptions too. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/style/StyleRareInheritedData.h ('k') | third_party/WebKit/Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp

diff --git a/third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp b/third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp

index 9a315702e86f2f42555ee2dd3d69c1aff0bf7180..1395f1a53d38dafd15371b43c734c96a8b62fc18 100644

--- a/third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp

+++ b/third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp

@@ -63,7 +63,6 @@ StyleRareInheritedData::StyleRareInheritedData()

, m_effectiveZoom(ComputedStyle::initialZoom())

, widows(ComputedStyle::initialWidows())

, orphans(ComputedStyle::initialOrphans())

- , m_hasAutoOrphans(true)

, m_textStrokeColorIsCurrentColor(true)

, m_textFillColorIsCurrentColor(true)

, m_textEmphasisColorIsCurrentColor(true)

@@ -120,7 +119,6 @@ StyleRareInheritedData::StyleRareInheritedData(const StyleRareInheritedData& o)

, m_effectiveZoom(o.m_effectiveZoom)

, widows(o.widows)

, orphans(o.orphans)

- , m_hasAutoOrphans(o.m_hasAutoOrphans)

, m_textStrokeColorIsCurrentColor(o.m_textStrokeColorIsCurrentColor)

, m_textFillColorIsCurrentColor(o.m_textFillColorIsCurrentColor)

, m_textEmphasisColorIsCurrentColor(o.m_textEmphasisColorIsCurrentColor)

@@ -185,7 +183,6 @@ bool StyleRareInheritedData::operator==(const StyleRareInheritedData& o) const

&& m_effectiveZoom == o.m_effectiveZoom

&& widows == o.widows

&& orphans == o.orphans

- && m_hasAutoOrphans == o.m_hasAutoOrphans

&& m_textStrokeColorIsCurrentColor == o.m_textStrokeColorIsCurrentColor

&& m_textFillColorIsCurrentColor == o.m_textFillColorIsCurrentColor

&& m_textEmphasisColorIsCurrentColor == o.m_textEmphasisColorIsCurrentColor