Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1905273002: Fix positioning of Mac permission prompts when fullscreen. (Closed)

Created:
4 years, 8 months ago by benwells
Modified:
4 years, 7 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix positioning of Mac permission prompts when fullscreen. When fullscreen on Mac OS X the location bar may or may not be visible. If it is not visible, permission bubbles should be positioned in the center of the screen. BUG=604085 Committed: https://crrev.com/070786c56dafefdaa631a66c4248e7689e91b0fc Cr-Commit-Position: refs/heads/master@{#390596}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Rebase #

Patch Set 3 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -37 lines) Patch
M chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm View 1 2 3 chunks +59 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm View 1 2 3 chunks +28 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm View 4 chunks +10 lines, -14 lines 0 comments Download
M ui/base/test/scoped_fake_nswindow_fullscreen.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/test/scoped_fake_nswindow_fullscreen.mm View 1 2 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
benwells
4 years, 8 months ago (2016-04-22 04:05:05 UTC) #2
tapted
Not sure if you want to deal with popups in this CL too... "They're weirder." ...
4 years, 8 months ago (2016-04-22 05:27:40 UTC) #3
benwells
https://codereview.chromium.org/1905273002/diff/1/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm File chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm (right): https://codereview.chromium.org/1905273002/diff/1/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm#newcode38 chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm:38: while (faker.IsInTransition()) On 2016/04/22 05:27:40, tapted wrote: > This ...
4 years, 7 months ago (2016-04-28 07:32:44 UTC) #4
benwells
https://codereview.chromium.org/1905273002/diff/1/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm File chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm (right): https://codereview.chromium.org/1905273002/diff/1/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm#newcode38 chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm:38: while (faker.IsInTransition()) On 2016/04/22 05:27:40, tapted wrote: > This ...
4 years, 7 months ago (2016-04-28 07:32:44 UTC) #5
tapted
lgtm
4 years, 7 months ago (2016-04-29 06:44:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905273002/40001
4 years, 7 months ago (2016-04-29 06:49:59 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-29 06:54:53 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:24:27 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/070786c56dafefdaa631a66c4248e7689e91b0fc
Cr-Commit-Position: refs/heads/master@{#390596}

Powered by Google App Engine
This is Rietveld 408576698