Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

Issue 1905273002: Fix positioning of Mac permission prompts when fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_PERMISSION_BUBBLE_COCOA_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_PERMISSION_BUBBLE_COCOA_H_
6 #define CHROME_BROWSER_UI_COCOA_PERMISSION_BUBBLE_COCOA_H_ 6 #define CHROME_BROWSER_UI_COCOA_PERMISSION_BUBBLE_COCOA_H_
7 7
8 #import <Foundation/Foundation.h> 8 #import <Foundation/Foundation.h>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 22 matching lines...) Expand all
33 void UpdateAnchorPosition() override; 33 void UpdateAnchorPosition() override;
34 gfx::NativeWindow GetNativeWindow() override; 34 gfx::NativeWindow GetNativeWindow() override;
35 35
36 // Called when |bubbleController_| is closing. 36 // Called when |bubbleController_| is closing.
37 void OnBubbleClosing(); 37 void OnBubbleClosing();
38 38
39 private: 39 private:
40 FRIEND_TEST_ALL_PREFIXES(PermissionBubbleBrowserTest, 40 FRIEND_TEST_ALL_PREFIXES(PermissionBubbleBrowserTest,
41 HasLocationBarByDefault); 41 HasLocationBarByDefault);
42 FRIEND_TEST_ALL_PREFIXES(PermissionBubbleBrowserTest, 42 FRIEND_TEST_ALL_PREFIXES(PermissionBubbleBrowserTest,
43 FullscreenHasLocationBar); 43 BrowserFullscreenHasLocationBar);
44 FRIEND_TEST_ALL_PREFIXES(PermissionBubbleBrowserTest,
45 TabFullscreenHasLocationBar);
44 FRIEND_TEST_ALL_PREFIXES(PermissionBubbleBrowserTest, AppHasNoLocationBar); 46 FRIEND_TEST_ALL_PREFIXES(PermissionBubbleBrowserTest, AppHasNoLocationBar);
45 FRIEND_TEST_ALL_PREFIXES(PermissionBubbleKioskBrowserTest, 47 FRIEND_TEST_ALL_PREFIXES(PermissionBubbleKioskBrowserTest,
46 KioskHasNoLocationBar); 48 KioskHasNoLocationBar);
47 49
48 Browser* browser_; // Weak. 50 Browser* browser_; // Weak.
49 Delegate* delegate_; // Weak. 51 Delegate* delegate_; // Weak.
50 52
51 // Cocoa-side UI controller for the bubble. Weak, as it will close itself. 53 // Cocoa-side UI controller for the bubble. Weak, as it will close itself.
52 PermissionBubbleController* bubbleController_; 54 PermissionBubbleController* bubbleController_;
53 55
54 DISALLOW_COPY_AND_ASSIGN(PermissionBubbleCocoa); 56 DISALLOW_COPY_AND_ASSIGN(PermissionBubbleCocoa);
55 }; 57 };
56 58
57 #endif // CHROME_BROWSER_UI_COCOA_PERMISSION_BUBBLE_COCOA_H_ 59 #endif // CHROME_BROWSER_UI_COCOA_PERMISSION_BUBBLE_COCOA_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698