chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h - Issue 1905273002: Fix positioning of Mac permission prompts when fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

Issue 1905273002: Fix positioning of Mac permission prompts when fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

index 3b2fff917b30ffb0343489de1291c83e945ed1b9..ddc16bd9ca953c050b73846d9746ce827423140b 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

@@ -40,7 +40,9 @@ class PermissionBubbleCocoa : public PermissionBubbleView {

FRIEND_TEST_ALL_PREFIXES(PermissionBubbleBrowserTest,

HasLocationBarByDefault);

FRIEND_TEST_ALL_PREFIXES(PermissionBubbleBrowserTest,

- FullscreenHasLocationBar);

+ BrowserFullscreenHasLocationBar);

+ FRIEND_TEST_ALL_PREFIXES(PermissionBubbleBrowserTest,

+ TabFullscreenHasLocationBar);

FRIEND_TEST_ALL_PREFIXES(PermissionBubbleBrowserTest, AppHasNoLocationBar);

FRIEND_TEST_ALL_PREFIXES(PermissionBubbleKioskBrowserTest,

KioskHasNoLocationBar);

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm » ('j') | no next file with comments »