Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3162)

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm

Issue 1905273002: Fix positioning of Mac permission prompts when fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
index 004dcd17a16c0784c0d6807b096f8475805afbc4..cea377c7f5e332760b9f968849d96c9efd837ff1 100644
--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
@@ -48,14 +48,14 @@
@end
@implementation MockBubbleYesLocationBar
-- (bool)hasLocationBar { return true; }
+- (bool)hasVisibleLocationBar { return true; }
@end
@interface MockBubbleNoLocationBar : NSObject
@end
@implementation MockBubbleNoLocationBar
-- (bool)hasLocationBar { return false; }
+- (bool)hasVisibleLocationBar { return false; }
@end
namespace {
@@ -352,9 +352,8 @@ TEST_F(PermissionBubbleControllerTest, ExitFullscreen) {
TEST_F(PermissionBubbleControllerTest, AnchorPositionWithLocationBar) {
base::mac::ScopedObjCClassSwizzler locationSwizzle(
- [PermissionBubbleController class],
- [MockBubbleYesLocationBar class],
- @selector(hasLocationBar));
+ [PermissionBubbleController class], [MockBubbleYesLocationBar class],
+ @selector(hasVisibleLocationBar));
NSPoint anchor = [controller_ getExpectedAnchorPoint];
@@ -370,9 +369,8 @@ TEST_F(PermissionBubbleControllerTest, AnchorPositionWithLocationBar) {
TEST_F(PermissionBubbleControllerTest, AnchorPositionWithoutLocationBar) {
base::mac::ScopedObjCClassSwizzler locationSwizzle(
- [PermissionBubbleController class],
- [MockBubbleNoLocationBar class],
- @selector(hasLocationBar));
+ [PermissionBubbleController class], [MockBubbleNoLocationBar class],
+ @selector(hasVisibleLocationBar));
NSPoint anchor = [controller_ getExpectedAnchorPoint];
@@ -389,18 +387,16 @@ TEST_F(PermissionBubbleControllerTest,
NSPoint withLocationBar;
{
base::mac::ScopedObjCClassSwizzler locationSwizzle(
- [PermissionBubbleController class],
- [MockBubbleYesLocationBar class],
- @selector(hasLocationBar));
+ [PermissionBubbleController class], [MockBubbleYesLocationBar class],
+ @selector(hasVisibleLocationBar));
withLocationBar = [controller_ getExpectedAnchorPoint];
}
NSPoint withoutLocationBar;
{
base::mac::ScopedObjCClassSwizzler locationSwizzle(
- [PermissionBubbleController class],
- [MockBubbleNoLocationBar class],
- @selector(hasLocationBar));
+ [PermissionBubbleController class], [MockBubbleNoLocationBar class],
+ @selector(hasVisibleLocationBar));
withoutLocationBar = [controller_ getExpectedAnchorPoint];
}

Powered by Google App Engine
This is Rietveld 408576698