chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h - Issue 1905273002: Fix positioning of Mac permission prompts when fullscreen.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

Issue 1905273002: Fix positioning of Mac permission prompts when fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm ('K') | « chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm ('k') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm » ('j') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import <Cocoa/Cocoa.h>	5 #import <Cocoa/Cocoa.h>

6	6

7 #include "base/mac/scoped_nsobject.h"	7 #include "base/mac/scoped_nsobject.h"

8 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"	8 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"

9 #include "chrome/browser/ui/website_settings/permission_bubble_view.h"	9 #include "chrome/browser/ui/website_settings/permission_bubble_view.h"

10 #include "ui/base/models/simple_menu_model.h"	10 #include "ui/base/models/simple_menu_model.h"

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42 forRequests:(const std::vector<PermissionBubbleRequest*>&)requests	42 forRequests:(const std::vector<PermissionBubbleRequest*>&)requests

43 acceptStates:(const std::vector<bool>&)acceptStates;	43 acceptStates:(const std::vector<bool>&)acceptStates;

44	44

45 // Will reposition the bubble based in case the anchor or parent should change.	45 // Will reposition the bubble based in case the anchor or parent should change.

46 - (void)updateAnchorPosition;	46 - (void)updateAnchorPosition;

47	47

48 // Will calculate the expected anchor point for this bubble.	48 // Will calculate the expected anchor point for this bubble.

49 // Should only be used outside this class for tests.	49 // Should only be used outside this class for tests.

50 - (NSPoint)getExpectedAnchorPoint;	50 - (NSPoint)getExpectedAnchorPoint;

51	51

52 // Returns true of the browser has support for the location bar.	52 // Returns true of the browser has a visible location bar.
	tapted 2016/04/22 05:27:40 nit: of -> if nit: of -> if benwells 2016/04/28 07:32:43 Done. Show quoted text On 2016/04/22 05:27:40, tapted wrote: > nit: of -> if Done.
53 // Should only be used outside this class for tests.	53 // Should only be used outside this class for tests.

54 - (bool)hasLocationBar;	54 - (bool)hasVisibleLocationBar;

55	55

56 @end	56 @end

OLD	NEW