Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1904653002: CC Animation: Merge LayerAnimationController into ElementAnimations. (Closed)

Created:
4 years, 8 months ago by loyso (OOO)
Modified:
4 years, 8 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Merge LayerAnimationController into ElementAnimations. BUG=595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751 Cr-Commit-Position: refs/heads/master@{#388974}

Patch Set 1 #

Patch Set 2 : Fix the tests. #

Patch Set 3 : Renaming. Remove ValueObserver. Use CreateEvents. #

Patch Set 4 : Refactor AnimationHost::RegisterPlayerForLayer. #

Total comments: 1

Patch Set 5 : Clean up includes and forward declarations. #

Patch Set 6 : Minor optimization: Don't init value observations if same host. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4871 lines, -5350 lines) Patch
M cc/BUILD.gn View 1 2 3 4 2 chunks +0 lines, -5 lines 0 comments Download
M cc/animation/animation.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M cc/animation/animation_host.h View 6 chunks +21 lines, -30 lines 0 comments Download
M cc/animation/animation_host.cc View 1 2 3 4 5 22 chunks +139 lines, -141 lines 0 comments Download
M cc/animation/animation_player.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M cc/animation/animation_player.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M cc/animation/animation_player_unittest.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M cc/animation/element_animations.h View 1 2 3 4 chunks +209 lines, -66 lines 0 comments Download
M cc/animation/element_animations.cc View 1 2 3 8 chunks +1156 lines, -77 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 1 2 2 chunks +3020 lines, -0 lines 0 comments Download
D cc/animation/layer_animation_controller.h View 1 chunk +0 lines, -271 lines 0 comments Download
D cc/animation/layer_animation_controller.cc View 1 chunk +0 lines, -1242 lines 0 comments Download
D cc/animation/layer_animation_controller_unittest.cc View 1 chunk +0 lines, -3163 lines 0 comments Download
D cc/animation/layer_animation_value_observer.h View 1 chunk +0 lines, -39 lines 0 comments Download
D cc/animation/layer_animation_value_provider.h View 1 chunk +0 lines, -28 lines 0 comments Download
M cc/cc.gyp View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/test/animation_test_common.h View 1 2 3 4 3 chunks +19 lines, -82 lines 0 comments Download
M cc/test/animation_test_common.cc View 5 chunks +38 lines, -101 lines 0 comments Download
M cc/test/animation_timelines_test_common.h View 9 chunks +56 lines, -17 lines 0 comments Download
M cc/test/animation_timelines_test_common.cc View 9 chunks +160 lines, -21 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 3 4 4 chunks +3 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/layer_animator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/compositor/layer_animator.cc View 4 chunks +15 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
loyso (OOO)
4 years, 8 months ago (2016-04-20 06:43:00 UTC) #4
ajuma
At least some of the test failures look real, so holding off reviewing this for ...
4 years, 8 months ago (2016-04-20 13:13:09 UTC) #5
loyso (OOO)
PTAL! I will rename "observ*" with "updates" for ElementAnimations in next CL.
4 years, 8 months ago (2016-04-21 02:55:06 UTC) #6
loyso (OOO)
https://codereview.chromium.org/1904653002/diff/60001/cc/animation/element_animations.h File cc/animation/element_animations.h (right): https://codereview.chromium.org/1904653002/diff/60001/cc/animation/element_animations.h#newcode44 cc/animation/element_animations.h:44: enum class ObserverType { ACTIVE, PENDING }; This is ...
4 years, 8 months ago (2016-04-21 05:07:57 UTC) #7
ajuma
lgtm
4 years, 8 months ago (2016-04-21 15:28:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904653002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904653002/100001
4 years, 8 months ago (2016-04-22 00:25:11 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-04-22 00:30:22 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:42:22 UTC) #15
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/47a0f19c0ea71537c0465269e6145d30678b0751
Cr-Commit-Position: refs/heads/master@{#388974}

Powered by Google App Engine
This is Rietveld 408576698