Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1911283002: CC Animation: Erase ElementAnimations::ObserverType. (Closed)

Created:
4 years, 8 months ago by loyso (OOO)
Modified:
4 years, 8 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mergelac
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Erase ElementAnimations::ObserverType. Use LayerTreeType instead. BUG=595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/9419f1a2b215d272c08bea8a01b7a45629843ce9 Cr-Commit-Position: refs/heads/master@{#389642}

Patch Set 1 #

Patch Set 2 : Prefer forward declarations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -214 lines) Patch
M cc/animation/animation_host.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M cc/animation/animation_host.cc View 1 10 chunks +10 lines, -21 lines 0 comments Download
M cc/animation/element_animations.h View 1 3 chunks +5 lines, -7 lines 0 comments Download
M cc/animation/element_animations.cc View 1 8 chunks +17 lines, -17 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 17 chunks +168 lines, -168 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
loyso (OOO)
4 years, 8 months ago (2016-04-22 04:37:42 UTC) #4
Ian Vollick
On 2016/04/22 04:37:42, loyso wrote: lgtm.
4 years, 8 months ago (2016-04-22 13:38:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911283002/20001
4 years, 8 months ago (2016-04-25 23:37:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 00:53:06 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 00:54:42 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9419f1a2b215d272c08bea8a01b7a45629843ce9
Cr-Commit-Position: refs/heads/master@{#389642}

Powered by Google App Engine
This is Rietveld 408576698