Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h

Issue 1902073002: Hoist "layout size changed" check out of SVGLayoutSupport::layoutChildren (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-container-layout-cleanup-2
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h
diff --git a/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h b/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h
index 4dfbf1582f52942e94cfd25252bf0ce1ee4f717d..a43dc05dc80deac50bb9f8ef3043eed52474e339 100644
--- a/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h
+++ b/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h
@@ -50,7 +50,7 @@ class CORE_EXPORT SVGLayoutSupport {
STATIC_ONLY(SVGLayoutSupport);
public:
// Shares child layouting code between LayoutSVGRoot/LayoutSVG(Hidden)Container
- static void layoutChildren(LayoutObject*, bool forceLayout, bool transformChanged);
+ static void layoutChildren(LayoutObject*, bool forceLayout, bool transformChanged, bool layoutSizeChanged);
// Layout resources used by this node.
static void layoutResourcesIfNeeded(const LayoutObject*);
@@ -91,6 +91,9 @@ public:
// Determines if any ancestor's transform has changed.
static bool transformToRootChanged(const LayoutObject*);
+ // Determines if any ancestor's layout size has changed.
+ static bool layoutSizeOfNearestViewportChanged(const LayoutObject*);
+
// FIXME: These methods do not belong here.
static const LayoutSVGRoot* findTreeRootObject(const LayoutObject*);
@@ -112,7 +115,6 @@ public:
private:
static void updateObjectBoundingBox(FloatRect& objectBoundingBox, bool& objectBoundingBoxValid, LayoutObject* other, FloatRect otherBoundingBox);
- static bool layoutSizeOfNearestViewportChanged(const LayoutObject* start);
};
class SubtreeContentTransformScope {

Powered by Google App Engine
This is Rietveld 408576698