Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

Issue 1902073002: Hoist "layout size changed" check out of SVGLayoutSupport::layoutChildren (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-container-layout-cleanup-2
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
index b219126ea4ef1f94f462b21560c6641f1eea4572..54c36f347df51d2c48b70be67b99f1ea546547d3 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
@@ -61,12 +61,17 @@ void LayoutSVGContainer::layout()
bool transformChanged = SVGLayoutSupport::transformToRootChanged(this);
+ // When hasRelativeLengths() is false, no descendants have relative lengths
+ // (hence no one is interested in viewport size changes).
+ bool layoutSizeChanged = element()->hasRelativeLengths()
+ && SVGLayoutSupport::layoutSizeOfNearestViewportChanged(this);
+
// If any of this container's children need to be laid out, and a filter is
// applied to the container, we need to issue paint invalidations for all
// the descendants.
bool forceLayoutOfChildren = selfNeedsLayout()
|| (normalChildNeedsLayout() && SVGLayoutSupport::hasFilterResource(*this));
- SVGLayoutSupport::layoutChildren(this, forceLayoutOfChildren, transformChanged);
+ SVGLayoutSupport::layoutChildren(this, forceLayoutOfChildren, transformChanged, layoutSizeChanged);
// Invalidate all resources of this client if our layout changed.
if (everHadLayout() && needsLayout())
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698