Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1897273002: Pass first child to SVGLayoutSupport::layoutChildren (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-container-layout-cleanup-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass first child to SVGLayoutSupport::layoutChildren Since everything depending on the "subtree root" has now been hoisted into the callers, we can pass firstChild() instead and avoid calling slowFirstChild(). BUG=603956 Committed: https://crrev.com/4526eaa97722bae66029643bca144b9903eaacd9 Cr-Commit-Position: refs/heads/master@{#388337}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
fs
This kind of jumps past the "selfNeedsLayout()" question mark, but I had it queued already ...
4 years, 8 months ago (2016-04-19 19:42:14 UTC) #2
pdr.
On 2016/04/19 at 19:42:14, fs wrote: > This kind of jumps past the "selfNeedsLayout()" question ...
4 years, 8 months ago (2016-04-19 20:28:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897273002/1
4 years, 8 months ago (2016-04-19 22:43:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 22:48:18 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:17:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4526eaa97722bae66029643bca144b9903eaacd9
Cr-Commit-Position: refs/heads/master@{#388337}

Powered by Google App Engine
This is Rietveld 408576698