Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1901773002: Removes most of aura dependencies from DefaultState (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@wm_window_positioner
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes most of aura dependencies from DefaultState The last remaining bit is for docking, which will come later. BUG=603369 TEST=none R=oshima@chromium.org Committed: https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6 Cr-Commit-Position: refs/heads/master@{#388385}

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 2

Patch Set 3 : nit and merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+427 lines, -411 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 6 chunks +12 lines, -11 lines 0 comments Download
M ash/ash.gyp View 1 2 4 chunks +6 lines, -3 lines 0 comments Download
M ash/frame/caption_buttons/frame_size_button.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M ash/root_window_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 2 3 chunks +8 lines, -7 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 2 6 chunks +16 lines, -14 lines 0 comments Download
M ash/wm/aura/wm_globals_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/aura/wm_globals_aura.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ash/wm/aura/wm_root_window_controller_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/aura/wm_root_window_controller_aura.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/wm/aura/wm_window_aura.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ash/wm/aura/wm_window_aura.cc View 3 chunks +16 lines, -0 lines 0 comments Download
A ash/wm/common/window_animation_types.h View 1 1 chunk +27 lines, -0 lines 0 comments Download
A ash/wm/common/window_parenting_utils.h View 1 chunk +31 lines, -0 lines 0 comments Download
A ash/wm/common/window_parenting_utils.cc View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M ash/wm/common/window_positioning_utils.h View 2 chunks +12 lines, -0 lines 0 comments Download
M ash/wm/common/window_positioning_utils.cc View 2 chunks +31 lines, -0 lines 0 comments Download
A + ash/wm/common/window_state_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/common/window_state_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/common/wm_globals.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/wm/common/wm_root_window_controller.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/wm/common/wm_window.h View 3 chunks +9 lines, -0 lines 0 comments Download
A + ash/wm/common/workspace/workspace_types.h View 2 chunks +5 lines, -3 lines 0 comments Download
M ash/wm/default_state.cc View 23 chunks +95 lines, -118 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 1 2 5 chunks +10 lines, -5 lines 0 comments Download
M ash/wm/dock/docked_window_resizer.cc View 4 chunks +14 lines, -9 lines 0 comments Download
M ash/wm/lock_window_state.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M ash/wm/panels/panel_window_resizer.cc View 1 2 3 chunks +9 lines, -2 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M ash/wm/window_animations.h View 1 chunk +0 lines, -10 lines 0 comments Download
M ash/wm/window_animations.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M ash/wm/window_animations_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
D ash/wm/window_state_util.h View 1 chunk +0 lines, -19 lines 0 comments Download
D ash/wm/window_state_util.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M ash/wm/window_util.h View 1 chunk +0 lines, -28 lines 0 comments Download
M ash/wm/window_util.cc View 3 chunks +0 lines, -73 lines 0 comments Download
D ash/wm/workspace/workspace_types.h View 1 chunk +0 lines, -27 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/wm/workspace_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace_controller.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/solid_color_user_wallpaper_delegate.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sky
4 years, 8 months ago (2016-04-18 18:01:40 UTC) #1
oshima
lgtm https://codereview.chromium.org/1901773002/diff/20001/ash/wm/common/window_parenting_utils.cc File ash/wm/common/window_parenting_utils.cc (right): https://codereview.chromium.org/1901773002/diff/20001/ash/wm/common/window_parenting_utils.cc#newcode25 ash/wm/common/window_parenting_utils.cc:25: } nit: nuke {}
4 years, 8 months ago (2016-04-18 22:15:52 UTC) #2
sky
https://codereview.chromium.org/1901773002/diff/20001/ash/wm/common/window_parenting_utils.cc File ash/wm/common/window_parenting_utils.cc (right): https://codereview.chromium.org/1901773002/diff/20001/ash/wm/common/window_parenting_utils.cc#newcode25 ash/wm/common/window_parenting_utils.cc:25: } On 2016/04/18 22:15:52, oshima wrote: > nit: nuke ...
4 years, 8 months ago (2016-04-20 00:08:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901773002/40001
4 years, 8 months ago (2016-04-20 00:13:10 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-20 00:54:02 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:19:14 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6
Cr-Commit-Position: refs/heads/master@{#388385}

Powered by Google App Engine
This is Rietveld 408576698