Basic display management for mus

Basic display management for mus

Add a basic single-display manager to mus sufficient to configure a single
attached Display.

BUG=558602
Committed: https://crrev.com/05b772d9beb759082cbe467ad466962dd669cc3e
Cr-Commit-Position: refs/heads/master@{#391969}

[rjkroege, 2016-04-18 21:11:24]

rjkroege@chromium.org changed reviewers:
+ sky@chromium.org

[rjkroege, 2016-04-18 21:11:24]

ptal

[sky, 2016-04-18 21:25:00]

https://codereview.chromium.org/1899923002/diff/1/components/mus/ws/platform_...
File components/mus/ws/platform_display.cc (right):

https://codereview.chromium.org/1899923002/diff/1/components/mus/ws/platform_...
components/mus/ws/platform_display.cc:499:
native_display_delegate_->UngrabServer();
What happens if this is deleted after OnConfigurationChanged but before
OnDisplaysAquired?

https://codereview.chromium.org/1899923002/diff/1/components/mus/ws/platform_...
components/mus/ws/platform_display.cc:505: base::Unretained(this)));
How is unretained safe here?

https://codereview.chromium.org/1899923002/diff/1/components/mus/ws/platform_...
File components/mus/ws/platform_display.h (right):

https://codereview.chromium.org/1899923002/diff/1/components/mus/ws/platform_...
components/mus/ws/platform_display.h:139: // Additional display management
callbacks.
Make these private?

[rjkroege, 2016-04-21 20:19:53]

ptal

https://codereview.chromium.org/1899923002/diff/1/components/mus/ws/platform_...
File components/mus/ws/platform_display.cc (right):

https://codereview.chromium.org/1899923002/diff/1/components/mus/ws/platform_...
components/mus/ws/platform_display.cc:499:
native_display_delegate_->UngrabServer();
On 2016/04/18 21:25:00, sky wrote:
> What happens if this is deleted after OnConfigurationChanged but before
> OnDisplaysAquired?

Something bad. Appropriate weak pointer-y stuff added.

https://codereview.chromium.org/1899923002/diff/1/components/mus/ws/platform_...
components/mus/ws/platform_display.cc:505: base::Unretained(this)));
On 2016/04/18 21:25:00, sky wrote:
> How is unretained safe here?

It's not. Fixed.

https://codereview.chromium.org/1899923002/diff/1/components/mus/ws/platform_...
File components/mus/ws/platform_display.h (right):

https://codereview.chromium.org/1899923002/diff/1/components/mus/ws/platform_...
components/mus/ws/platform_display.h:139: // Additional display management
callbacks.
On 2016/04/18 21:25:00, sky wrote:
> Make these private?

Done.

[rjkroege, 2016-05-02 23:15:58]

ptal

[sky, 2016-05-03 02:39:51]

https://codereview.chromium.org/1899923002/diff/40001/components/mus/mus_app.cc
File components/mus/mus_app.cc (right):

https://codereview.chromium.org/1899923002/diff/40001/components/mus/mus_app....
components/mus/mus_app.cc:213: void
MandolineUIServicesApp::CreatePhysicalDisplayCallback(int64_t id,
Make position match that of header.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/mus_app.h
File components/mus/mus_app.h (right):

https://codereview.chromium.org/1899923002/diff/40001/components/mus/mus_app....
components/mus/mus_app.h:30: #include "ui/gfx/geometry/rect.h"
forward declare rect.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/mus_app....
components/mus/mus_app.h:124: void CreatePhysicalDisplayCallback(int64_t id,
gfx::Rect bounds);
const gfx::Rect&, document what id is, and name this OnCreatedPhysicalDisplay.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/displ...
File components/mus/ws/display.h (right):

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/displ...
components/mus/ws/display.h:152: void SetBounds(gfx::Rect bounds);
const gfx::Rect&, and move this around line 148 (generally try to keep overrides
and non-overrides grouped together). That said, I don't think you actually use
this.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
File components/mus/ws/platform_screen.cc (right):

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.cc:30:
base::ThreadTaskRunnerHandle::Get()->PostTask(
Why does this need to be async?

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
File components/mus/ws/platform_screen.h (right):

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:26: // In Chrome, a "Screen" is the
aggregate of all attached physical displays.
nit: remove this first sentence as it's confusing in this context.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:34: // When using Ozone, PlatformScreen must
be initialized after the Ozone
This is confusing. I think you want something like Initializes platform specific
screen resources.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:40: typedef base::Callback<void(int64_t,
gfx::Rect)> ConfiguredDisplayCallback;
Use 'using' instead. It is way easier to read.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:42: // |ConfigurePhysicalDisplay| configures
a single physical display and returns
nit: generally |s are for references to parameters and members, () is for
functions.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:44: void
ConfigurePhysicalDisplay(ConfiguredDisplayCallback callback);
const&

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:47: void
FixedSizeScreenConfiguration(ConfiguredDisplayCallback callback);
Add a description as this isn't obvious.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:55: void
OnDisplaysAquired(ConfiguredDisplayCallback callback,
const&

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:57: void
OnDisplayConfigured(ConfiguredDisplayCallback callback,
const&

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:64: bool is_configuring_;
Initialize here (or update platform_screen.cc to initialize this and
should_configure_).

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:76:
DISALLOW_COPY_AND_ASSIGN(PlatformScreen);
nit: newline between 75/76.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
File components/mus/ws/platform_screen_ozone.cc (right):

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen_ozone.cc:63: if (callback_.is_null()) {
nit: no {}

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen_ozone.cc:66: if (is_configuring_) {
nit: no {}

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen_ozone.cc:73: weak_ptr_factory_.GetWeakPtr(),
callback_));
Why do you need both a member for the callback and pass the callback around?

[rjkroege, 2016-05-03 21:03:04]

ptal

https://codereview.chromium.org/1899923002/diff/40001/components/mus/mus_app.cc
File components/mus/mus_app.cc (right):

https://codereview.chromium.org/1899923002/diff/40001/components/mus/mus_app....
components/mus/mus_app.cc:213: void
MandolineUIServicesApp::CreatePhysicalDisplayCallback(int64_t id,
On 2016/05/03 02:39:50, sky wrote:
> Make position match that of header.

Done.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/mus_app.h
File components/mus/mus_app.h (right):

https://codereview.chromium.org/1899923002/diff/40001/components/mus/mus_app....
components/mus/mus_app.h:30: #include "ui/gfx/geometry/rect.h"
On 2016/05/03 02:39:50, sky wrote:
> forward declare rect.

Done.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/mus_app....
components/mus/mus_app.h:124: void CreatePhysicalDisplayCallback(int64_t id,
gfx::Rect bounds);
On 2016/05/03 02:39:50, sky wrote:
> const gfx::Rect&, document what id is, and name this OnCreatedPhysicalDisplay.

Done.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/displ...
File components/mus/ws/display.h (right):

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/displ...
components/mus/ws/display.h:152: void SetBounds(gfx::Rect bounds);
On 2016/05/03 02:39:51, sky wrote:
> const gfx::Rect&, and move this around line 148 (generally try to keep
overrides
> and non-overrides grouped together). That said, I don't think you actually use
> this.

Removed.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
File components/mus/ws/platform_screen.cc (right):

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.cc:30:
base::ThreadTaskRunnerHandle::Get()->PostTask(
On 2016/05/03 02:39:51, sky wrote:
> Why does this need to be async?

This way, it has the same callback semantics as the ozone version.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
File components/mus/ws/platform_screen.h (right):

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:26: // In Chrome, a "Screen" is the
aggregate of all attached physical displays.
On 2016/05/03 02:39:51, sky wrote:
> nit: remove this first sentence as it's confusing in this context.

Done.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:34: // When using Ozone, PlatformScreen must
be initialized after the Ozone
On 2016/05/03 02:39:51, sky wrote:
> This is confusing. I think you want something like Initializes platform
specific
> screen resources.

Re-worded to try to make the point that I was trying to make.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:40: typedef base::Callback<void(int64_t,
gfx::Rect)> ConfiguredDisplayCallback;
On 2016/05/03 02:39:51, sky wrote:
> Use 'using' instead. It is way easier to read.

Done.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:42: // |ConfigurePhysicalDisplay| configures
a single physical display and returns
On 2016/05/03 02:39:51, sky wrote:
> nit: generally |s are for references to parameters and members, () is for
> functions.

Done.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:44: void
ConfigurePhysicalDisplay(ConfiguredDisplayCallback callback);
On 2016/05/03 02:39:51, sky wrote:
> const&

Done.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:47: void
FixedSizeScreenConfiguration(ConfiguredDisplayCallback callback);
On 2016/05/03 02:39:51, sky wrote:
> Add a description as this isn't obvious.

Done.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:55: void
OnDisplaysAquired(ConfiguredDisplayCallback callback,
On 2016/05/03 02:39:51, sky wrote:
> const&

Done.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:57: void
OnDisplayConfigured(ConfiguredDisplayCallback callback,
On 2016/05/03 02:39:51, sky wrote:
> const&

Done.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:64: bool is_configuring_;
On 2016/05/03 02:39:51, sky wrote:
> Initialize here (or update platform_screen.cc to initialize this and
> should_configure_).

Done.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:76:
DISALLOW_COPY_AND_ASSIGN(PlatformScreen);
On 2016/05/03 02:39:51, sky wrote:
> nit: newline between 75/76.

Done.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
File components/mus/ws/platform_screen_ozone.cc (right):

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen_ozone.cc:63: if (callback_.is_null()) {
On 2016/05/03 02:39:51, sky wrote:
> nit: no {}

Done.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen_ozone.cc:66: if (is_configuring_) {
On 2016/05/03 02:39:51, sky wrote:
> nit: no {}

Done.

https://codereview.chromium.org/1899923002/diff/40001/components/mus/ws/platf...
components/mus/ws/platform_screen_ozone.cc:73: weak_ptr_factory_.GetWeakPtr(),
callback_));
On 2016/05/03 02:39:51, sky wrote:
> Why do you need both a member for the callback and pass the callback around?

OnConfigurationChanged() implements  NativeDisplayObserver so the callback can't
be passed into this function. Passing the callback around internally henceforth
means that multiple calls to ConfigurePhysicalDisplay() will each invoke the
provided callback.

[sky, 2016-05-03 23:33:40]

https://codereview.chromium.org/1899923002/diff/80001/components/mus/ws/platf...
File components/mus/ws/platform_screen.h (right):

https://codereview.chromium.org/1899923002/diff/80001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:28: class PlatformScreen : public
ui::NativeDisplayObserver {
I find the class confusing because it has a bunch of functions that are specific
to ozone. Can this class be pure virtual?

[rjkroege, 2016-05-04 01:37:40]

ptal

https://codereview.chromium.org/1899923002/diff/80001/components/mus/ws/platf...
File components/mus/ws/platform_screen.h (right):

https://codereview.chromium.org/1899923002/diff/80001/components/mus/ws/platf...
components/mus/ws/platform_screen.h:28: class PlatformScreen : public
ui::NativeDisplayObserver {
On 2016/05/03 23:33:39, sky wrote:
> I find the class confusing because it has a bunch of functions that are
specific
> to ozone. Can this class be pure virtual?

Done.

[sky, 2016-05-04 17:05:45]

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
File components/mus/ws/platform_screen.h (right):

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen.h:23: PlatformScreen();
You shouldn't need to have this.

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen.h:24: virtual ~PlatformScreen();
And inline this (we generally inline destructor for pure virtual classes like
this).

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen.h:32: using ConfiguredDisplayCallback =
base::Callback<void(int64_t, gfx::Rect)>;
const gfx::Rect&

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen.h:37: const ConfiguredDisplayCallback&
callback) = 0;
Do you expect this to be called more than once? It seems like this is a one time
call. Can this function be nuked and the callback supplied to Init()?

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
File components/mus/ws/platform_screen_impl.cc (right):

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl.cc:30: FROM_HERE,
base::Bind(&PlatformScreenImpl::FixedSizeScreenConfiguration,
You shouldn't need to route the callback through this and use a weakptr. Use a
function in an anonymous namespace.

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
File components/mus/ws/platform_screen_impl.h (right):

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl.h:31: using ConfiguredDisplayCallback =
base::Callback<void(int64_t, gfx::Rect)>;
This is already defined in PlatformScreen.

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl.h:35: void
FixedSizeScreenConfiguration(ConfiguredDisplayCallback callback);
const &

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
File components/mus/ws/platform_screen_impl_ozone.cc (right):

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl_ozone.cc:50:
base::Bind(&PlatformScreenImplOzone::FixedSizeScreenConfiguration,
Again, you shouldn't need a member function and the weak ptr for this.

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl_ozone.cc:63: if (callback_.is_null())
AFAICT you never reset the callback, so it will never be null?

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl_ozone.cc:65: if (is_configuring_)
How come you don't early out if is_configuring_ is true? If is_configuring_ is
true won't you end up back here shortly by way of the PostTask on 110?

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl_ozone.cc:122: const
ConfiguredDisplayCallback& callback,
Why do you pass callback here and have callback as a member?

[rjkroege, 2016-05-04 22:50:14]

ptal

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
File components/mus/ws/platform_screen.h (right):

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen.h:23: PlatformScreen();
On 2016/05/04 17:05:44, sky wrote:
> You shouldn't need to have this.

Done.

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen.h:24: virtual ~PlatformScreen();
On 2016/05/04 17:05:44, sky wrote:
> And inline this (we generally inline destructor for pure virtual classes like
> this).

Done. Aside: wasn't there a time when destructors needed to be in a .cc file to
link correctly?

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen.h:32: using ConfiguredDisplayCallback =
base::Callback<void(int64_t, gfx::Rect)>;
On 2016/05/04 17:05:44, sky wrote:
> const gfx::Rect&

Done.

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen.h:37: const ConfiguredDisplayCallback&
callback) = 0;
On 2016/05/04 17:05:44, sky wrote:
> Do you expect this to be called more than once? 

Eventually yes: split-mus restarting the mus-gpu or mash reconfiguring the
screen. At present, no.

> It seems like this is a one time
> call. Can this function be nuked and the callback supplied to Init()?

I think this is not a good idea as it combines code with different ordering
intents:

PlatformScreen::Init  - sets up the PlatformScreen class -- a process that might
be time consuming and should be started early as possible (e.g. before entering
a sandbox.)

PlatformScreen::ConfigurePhysicalDisplay - the ws thread is saying that it is
waiting for a configured physical display as soon as possible.

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
File components/mus/ws/platform_screen_impl.cc (right):

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl.cc:30: FROM_HERE,
base::Bind(&PlatformScreenImpl::FixedSizeScreenConfiguration,
On 2016/05/04 17:05:44, sky wrote:
> You shouldn't need to route the callback through this and use a weakptr. Use a
> function in an anonymous namespace.

Done.

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
File components/mus/ws/platform_screen_impl.h (right):

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl.h:31: using ConfiguredDisplayCallback =
base::Callback<void(int64_t, gfx::Rect)>;
On 2016/05/04 17:05:44, sky wrote:
> This is already defined in PlatformScreen.

Done.

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl.h:35: void
FixedSizeScreenConfiguration(ConfiguredDisplayCallback callback);
On 2016/05/04 17:05:44, sky wrote:
> const &

Done.

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
File components/mus/ws/platform_screen_impl_ozone.cc (right):

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl_ozone.cc:50:
base::Bind(&PlatformScreenImplOzone::FixedSizeScreenConfiguration,
On 2016/05/04 17:05:45, sky wrote:
> Again, you shouldn't need a member function and the weak ptr for this.

Done.

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl_ozone.cc:63: if (callback_.is_null())
On 2016/05/04 17:05:45, sky wrote:
> AFAICT you never reset the callback, so it will never be null?

No longer applicable.

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl_ozone.cc:65: if (is_configuring_)
On 2016/05/04 17:05:45, sky wrote:
> How come you don't early out if is_configuring_ is true? If is_configuring_ is
> true won't you end up back here shortly by way of the PostTask on 110?

Doh. Thanks for catching this. I had deleted that by accident since an earlier
version of this CL.

https://codereview.chromium.org/1899923002/diff/100001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl_ozone.cc:122: const
ConfiguredDisplayCallback& callback,
On 2016/05/04 17:05:45, sky wrote:
> Why do you pass callback here and have callback as a member?

Seemed like an easy way to ensure that I only called the callback once for each
call to ConfigurePhysicalDisplay without particularly modifying
OnConfigurationChanged. Refactored differently.

[sky, 2016-05-04 23:48:07]

LGTM

https://codereview.chromium.org/1899923002/diff/160001/components/mus/ws/plat...
File components/mus/ws/platform_screen_impl_ozone.cc (right):

https://codereview.chromium.org/1899923002/diff/160001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl_ozone.cc:114:
native_display_delegate_->UngrabServer();
If this is destroyed between ConfigurePhysicalDisplay and OnDisplaysAquired do
you need to UngrabServer?

[rjkroege, 2016-05-05 00:55:43]

https://codereview.chromium.org/1899923002/diff/160001/components/mus/ws/plat...
File components/mus/ws/platform_screen_impl_ozone.cc (right):

https://codereview.chromium.org/1899923002/diff/160001/components/mus/ws/plat...
components/mus/ws/platform_screen_impl_ozone.cc:114:
native_display_delegate_->UngrabServer();
On 2016/05/04 23:48:07, sky wrote:
> If this is destroyed between ConfigurePhysicalDisplay and OnDisplaysAquired do
> you need to UngrabServer?

Probably not. I should have removed the cals to Grab/Ungrab. Fixed.

[rjkroege, 2016-05-05 00:57:13]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-05-05 00:57:13]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1899923002/#ps180001
(title: "cleanup")

[commit-bot: I haz the power, 2016-05-05 00:57:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899923002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899923002/180001

[commit-bot: I haz the power, 2016-05-05 01:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 01:23:25]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[rjkroege, 2016-05-05 20:58:11]

I had to make a 1 line change to make the tests pass by setting the default size
of DefaultPlatformDisplay as before if the display is not created via
CreateDefaultDisplays.

PTAL.

[sky, 2016-05-05 21:25:08]

SLGTM

[rjkroege, 2016-05-05 22:06:08]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-05-05 22:06:09]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1899923002/#ps200001
(title: "tests pass")

[commit-bot: I haz the power, 2016-05-05 22:06:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899923002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899923002/200001

[commit-bot: I haz the power, 2016-05-05 22:15:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 22:15:46]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[rjkroege, 2016-05-05 22:56:15]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-05-05 22:56:15]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1899923002/#ps220001
(title: "fix chromecast build")

[commit-bot: I haz the power, 2016-05-05 22:56:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899923002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899923002/220001

[commit-bot: I haz the power, 2016-05-06 00:32:59]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-05-06 00:34:45]

Description was changed from

==========
Basic display management for mus

Add a basic single-display manager to mus sufficient to configure a single
attached Display.

BUG=558602
==========

to

==========
Basic display management for mus

Add a basic single-display manager to mus sufficient to configure a single
attached Display.

BUG=558602

Committed: https://crrev.com/05b772d9beb759082cbe467ad466962dd669cc3e
Cr-Commit-Position: refs/heads/master@{#391969}
==========

[commit-bot: I haz the power, 2016-05-06 00:34:46]

Patchset 12 (id:??) landed as
https://crrev.com/05b772d9beb759082cbe467ad466962dd669cc3e
Cr-Commit-Position: refs/heads/master@{#391969}