Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1899083003: Convert //extensions/renderer from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
Devlin
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //extensions/renderer from scoped_ptr to std::unique_ptr BUG=554298 Committed: https://crrev.com/f6f806674c4f6ebbb8b20197ae5b6c7a40bba08f Cr-Commit-Position: refs/heads/master@{#388568}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -292 lines) Patch
M extensions/renderer/activity_log_converter_strategy.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M extensions/renderer/activity_log_converter_strategy_unittest.cc View 7 chunks +11 lines, -9 lines 0 comments Download
M extensions/renderer/api/display_source/display_source_session.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/renderer/api/display_source/display_source_session.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_elementary_stream_descriptor.h View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_session.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_session.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M extensions/renderer/api/serial/data_receiver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api/serial/data_sender_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/api/serial/serial_api_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/api_activity_logger.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/api_test_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/api_test_base.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M extensions/renderer/app_window_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/dispatcher.h View 4 chunks +8 lines, -8 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 11 chunks +47 lines, -48 lines 0 comments Download
M extensions/renderer/display_source_custom_bindings.h View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/renderer/display_source_custom_bindings.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/event_bindings.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/event_bindings.cc View 5 chunks +13 lines, -11 lines 0 comments Download
M extensions/renderer/extension_injection_host.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/extension_injection_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/extensions_render_frame_observer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/renderer/gc_callback_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/i18n_custom_bindings.cc View 7 chunks +10 lines, -8 lines 0 comments Download
M extensions/renderer/json_schema_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/messaging_bindings.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M extensions/renderer/module_system.h View 8 chunks +10 lines, -8 lines 0 comments Download
M extensions/renderer/module_system.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/module_system_test.h View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/module_system_test.cc View 1 5 chunks +12 lines, -10 lines 0 comments Download
M extensions/renderer/module_system_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M extensions/renderer/mojo/stash_client_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/renderer/programmatic_script_injector.h View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/renderer/programmatic_script_injector.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/runtime_custom_bindings.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/renderer/safe_builtins.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/renderer/script_context.h View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/script_context.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/renderer/script_injection.h View 4 chunks +8 lines, -7 lines 0 comments Download
M extensions/renderer/script_injection.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M extensions/renderer/script_injection_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/script_injection_manager.cc View 9 chunks +12 lines, -15 lines 0 comments Download
M extensions/renderer/script_injector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/send_request_natives.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/set_icon_natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/test_features_native_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/user_script_injector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/user_script_injector.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/renderer/user_script_set.h View 4 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/user_script_set.cc View 5 chunks +12 lines, -17 lines 0 comments Download
M extensions/renderer/user_script_set_manager.h View 2 chunks +6 lines, -5 lines 0 comments Download
M extensions/renderer/user_script_set_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/v8_schema_registry.h View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/renderer/v8_schema_registry.cc View 1 4 chunks +7 lines, -6 lines 0 comments Download
M extensions/renderer/wake_event_page.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/wake_event_page.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/worker_script_context_set.h View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/renderer/worker_script_context_set.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
dcheng
4 years, 8 months ago (2016-04-19 18:46:54 UTC) #2
Devlin
lgtm
4 years, 8 months ago (2016-04-20 19:04:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899083003/1
4 years, 8 months ago (2016-04-20 19:08:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/22273) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-20 19:11:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899083003/20001
4 years, 8 months ago (2016-04-20 19:20:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 20:26:15 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:26:11 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6f806674c4f6ebbb8b20197ae5b6c7a40bba08f
Cr-Commit-Position: refs/heads/master@{#388568}

Powered by Google App Engine
This is Rietveld 408576698