Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: extensions/renderer/module_system.cc

Issue 1899083003: Convert //extensions/renderer from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/module_system.h ('k') | extensions/renderer/module_system_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/module_system.cc
diff --git a/extensions/renderer/module_system.cc b/extensions/renderer/module_system.cc
index ef97c818fc4f01aa5b9ac80e964afbbab7cfe99f..9f708bf3eac2cc04c19cba6b6b299a58c3f504ef 100644
--- a/extensions/renderer/module_system.cc
+++ b/extensions/renderer/module_system.cc
@@ -337,7 +337,7 @@ v8::Local<v8::Value> ModuleSystem::CallModuleMethod(
void ModuleSystem::RegisterNativeHandler(
const std::string& name,
- scoped_ptr<NativeHandler> native_handler) {
+ std::unique_ptr<NativeHandler> native_handler) {
ClobberExistingNativeHandler(name);
native_handler_map_[name] = std::move(native_handler);
}
@@ -566,7 +566,7 @@ void ModuleSystem::RequireAsync(
v8::Local<v8::Promise::Resolver> resolver(
v8::Promise::Resolver::New(v8_context).ToLocalChecked());
args.GetReturnValue().Set(resolver->GetPromise());
- scoped_ptr<v8::Global<v8::Promise::Resolver>> global_resolver(
+ std::unique_ptr<v8::Global<v8::Promise::Resolver>> global_resolver(
new v8::Global<v8::Promise::Resolver>(GetIsolate(), resolver));
gin::ModuleRegistry* module_registry =
gin::ModuleRegistry::From(v8_context);
@@ -735,7 +735,7 @@ void ModuleSystem::OnDidAddPendingModule(
}
void ModuleSystem::OnModuleLoaded(
- scoped_ptr<v8::Global<v8::Promise::Resolver>> resolver,
+ std::unique_ptr<v8::Global<v8::Promise::Resolver>> resolver,
v8::Local<v8::Value> value) {
if (!is_valid())
return;
« no previous file with comments | « extensions/renderer/module_system.h ('k') | extensions/renderer/module_system_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698