Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

Issue 1899083003: Convert //extensions/renderer from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
index f54c87891c75e53e129c2ca9ad6e37e494ae2ef2..ee7c11e6dd8237c69ab666b45d482010dde2bf36 100644
--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
@@ -147,10 +147,10 @@ void GuestViewInternalCustomBindings::AttachGuest(
int guest_instance_id = args[1]->Int32Value();
- scoped_ptr<base::DictionaryValue> params;
+ std::unique_ptr<base::DictionaryValue> params;
{
- scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
- scoped_ptr<base::Value> params_as_value(
+ std::unique_ptr<V8ValueConverter> converter(V8ValueConverter::create());
+ std::unique_ptr<base::Value> params_as_value(
converter->FromV8Value(args[2], context()->v8_context()));
params = base::DictionaryValue::From(std::move(params_as_value));
CHECK(params);
@@ -221,10 +221,10 @@ void GuestViewInternalCustomBindings::AttachIframeGuest(
int element_instance_id = args[0]->Int32Value();
int guest_instance_id = args[1]->Int32Value();
- scoped_ptr<base::DictionaryValue> params;
+ std::unique_ptr<base::DictionaryValue> params;
{
- scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
- scoped_ptr<base::Value> params_as_value(
+ std::unique_ptr<V8ValueConverter> converter(V8ValueConverter::create());
+ std::unique_ptr<base::Value> params_as_value(
converter->FromV8Value(args[2], context()->v8_context()));
params = base::DictionaryValue::From(std::move(params_as_value));
CHECK(params);

Powered by Google App Engine
This is Rietveld 408576698