Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: extensions/renderer/api/serial/serial_api_unittest.cc

Issue 1899083003: Convert //extensions/renderer from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api/serial/data_sender_unittest.cc ('k') | extensions/renderer/api_activity_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api/serial/serial_api_unittest.cc
diff --git a/extensions/renderer/api/serial/serial_api_unittest.cc b/extensions/renderer/api/serial/serial_api_unittest.cc
index 82f8f2a36f13f26ea7dac2cfff82147b440553e3..1aa8808b6bcb51d6004929bbce5bf58db88b88c7 100644
--- a/extensions/renderer/api/serial/serial_api_unittest.cc
+++ b/extensions/renderer/api/serial/serial_api_unittest.cc
@@ -422,7 +422,7 @@ class SerialApiTest : public ApiTestBase {
scoped_refptr<TestIoHandlerBase> io_handler_;
- scoped_ptr<StashBackend> stash_backend_;
+ std::unique_ptr<StashBackend> stash_backend_;
private:
scoped_refptr<device::SerialIoHandler> GetIoHandler() {
@@ -437,7 +437,7 @@ class SerialApiTest : public ApiTestBase {
new device::SerialConnectionFactory(
base::Bind(&SerialApiTest::GetIoHandler, base::Unretained(this)),
base::ThreadTaskRunnerHandle::Get()),
- scoped_ptr<device::SerialDeviceEnumerator>(
+ std::unique_ptr<device::SerialDeviceEnumerator>(
new FakeSerialDeviceEnumerator),
std::move(request));
}
@@ -702,7 +702,7 @@ TEST_F(SerialApiTest, SendUnknownConnectionId) {
// https://crbug.com/538774
TEST_F(SerialApiTest, DISABLED_StashAndRestoreDuringEcho) {
ASSERT_NO_FATAL_FAILURE(RunTest("serial_unittest.js", "testSendAndStash"));
- scoped_ptr<ModuleSystemTestEnvironment> new_env(CreateEnvironment());
+ std::unique_ptr<ModuleSystemTestEnvironment> new_env(CreateEnvironment());
ApiTestEnvironment new_api_test_env(new_env.get());
PrepareEnvironment(&new_api_test_env, stash_backend_.get());
new_api_test_env.RunTest("serial_unittest.js", "testRestoreAndReceive");
@@ -713,7 +713,7 @@ TEST_F(SerialApiTest, DISABLED_StashAndRestoreDuringEchoError) {
new ReceiveErrorTestIoHandler(device::serial::ReceiveError::DEVICE_LOST);
ASSERT_NO_FATAL_FAILURE(
RunTest("serial_unittest.js", "testRestoreAndReceiveErrorSetUp"));
- scoped_ptr<ModuleSystemTestEnvironment> new_env(CreateEnvironment());
+ std::unique_ptr<ModuleSystemTestEnvironment> new_env(CreateEnvironment());
ApiTestEnvironment new_api_test_env(new_env.get());
PrepareEnvironment(&new_api_test_env, stash_backend_.get());
new_api_test_env.RunTest("serial_unittest.js", "testRestoreAndReceiveError");
@@ -729,7 +729,7 @@ TEST_F(SerialApiTest, MAYBE_StashAndRestoreNoConnections) {
ASSERT_NO_FATAL_FAILURE(
RunTest("serial_unittest.js", "testStashNoConnections"));
io_handler_ = nullptr;
- scoped_ptr<ModuleSystemTestEnvironment> new_env(CreateEnvironment());
+ std::unique_ptr<ModuleSystemTestEnvironment> new_env(CreateEnvironment());
ApiTestEnvironment new_api_test_env(new_env.get());
PrepareEnvironment(&new_api_test_env, stash_backend_.get());
new_api_test_env.RunTest("serial_unittest.js", "testRestoreNoConnections");
« no previous file with comments | « extensions/renderer/api/serial/data_sender_unittest.cc ('k') | extensions/renderer/api_activity_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698