Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: extensions/renderer/module_system_test.h

Issue 1899083003: Convert //extensions/renderer from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | extensions/renderer/module_system_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_RENDERER_MODULE_SYSTEM_TEST_H_ 5 #ifndef EXTENSIONS_RENDERER_MODULE_SYSTEM_TEST_H_
6 #define EXTENSIONS_RENDERER_MODULE_SYSTEM_TEST_H_ 6 #define EXTENSIONS_RENDERER_MODULE_SYSTEM_TEST_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "extensions/renderer/module_system.h" 9 #include "extensions/renderer/module_system.h"
10 #include "extensions/renderer/script_context.h" 10 #include "extensions/renderer/script_context.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 ModuleSystem* module_system() { return context_->module_system(); } 48 ModuleSystem* module_system() { return context_->module_system(); }
49 49
50 ScriptContext* context() { return context_.get(); } 50 ScriptContext* context() { return context_.get(); }
51 51
52 v8::Isolate* isolate() { return isolate_; } 52 v8::Isolate* isolate() { return isolate_; }
53 53
54 AssertNatives* assert_natives() { return assert_natives_; } 54 AssertNatives* assert_natives() { return assert_natives_; }
55 55
56 private: 56 private:
57 v8::Isolate* isolate_; 57 v8::Isolate* isolate_;
58 scoped_ptr<gin::ContextHolder> context_holder_; 58 std::unique_ptr<gin::ContextHolder> context_holder_;
59 v8::HandleScope handle_scope_; 59 v8::HandleScope handle_scope_;
60 scoped_ptr<ScriptContext> context_; 60 std::unique_ptr<ScriptContext> context_;
61 AssertNatives* assert_natives_; 61 AssertNatives* assert_natives_;
62 scoped_ptr<StringSourceMap> source_map_; 62 std::unique_ptr<StringSourceMap> source_map_;
63 63
64 DISALLOW_COPY_AND_ASSIGN(ModuleSystemTestEnvironment); 64 DISALLOW_COPY_AND_ASSIGN(ModuleSystemTestEnvironment);
65 }; 65 };
66 66
67 // Test fixture for testing JS that makes use of the module system. 67 // Test fixture for testing JS that makes use of the module system.
68 // 68 //
69 // Typically tests will look like: 69 // Typically tests will look like:
70 // 70 //
71 // TEST_F(MyModuleSystemTest, TestStuff) { 71 // TEST_F(MyModuleSystemTest, TestStuff) {
72 // ModuleSystem::NativesEnabledScope natives_enabled(module_system_.get()); 72 // ModuleSystem::NativesEnabledScope natives_enabled(module_system_.get());
73 // RegisterModule("test", "requireNative('assert').AssertTrue(true);"); 73 // RegisterModule("test", "requireNative('assert').AssertTrue(true);");
74 // module_system_->Require("test"); 74 // module_system_->Require("test");
75 // } 75 // }
76 // 76 //
77 // By default a test will fail if no method in the native module 'assert' is 77 // By default a test will fail if no method in the native module 'assert' is
78 // called. This behaviour can be overridden by calling ExpectNoAssertionsMade(). 78 // called. This behaviour can be overridden by calling ExpectNoAssertionsMade().
79 class ModuleSystemTest : public testing::Test { 79 class ModuleSystemTest : public testing::Test {
80 public: 80 public:
81 ModuleSystemTest(); 81 ModuleSystemTest();
82 ~ModuleSystemTest() override; 82 ~ModuleSystemTest() override;
83 83
84 void SetUp() override; 84 void SetUp() override;
85 void TearDown() override; 85 void TearDown() override;
86 86
87 protected: 87 protected:
88 ModuleSystemTestEnvironment* env() { return env_.get(); } 88 ModuleSystemTestEnvironment* env() { return env_.get(); }
89 89
90 scoped_ptr<ModuleSystemTestEnvironment> CreateEnvironment(); 90 std::unique_ptr<ModuleSystemTestEnvironment> CreateEnvironment();
91 91
92 // Make the test fail if any asserts are called. By default a test will fail 92 // Make the test fail if any asserts are called. By default a test will fail
93 // if no asserts are called. 93 // if no asserts are called.
94 void ExpectNoAssertionsMade(); 94 void ExpectNoAssertionsMade();
95 95
96 // Runs promises that have been resolved. Resolved promises will not run 96 // Runs promises that have been resolved. Resolved promises will not run
97 // until this is called. 97 // until this is called.
98 void RunResolvedPromises(); 98 void RunResolvedPromises();
99 99
100 private: 100 private:
101 v8::Isolate* isolate_; 101 v8::Isolate* isolate_;
102 scoped_ptr<ModuleSystemTestEnvironment> env_; 102 std::unique_ptr<ModuleSystemTestEnvironment> env_;
103 bool should_assertions_be_made_; 103 bool should_assertions_be_made_;
104 104
105 private: 105 private:
106 DISALLOW_COPY_AND_ASSIGN(ModuleSystemTest); 106 DISALLOW_COPY_AND_ASSIGN(ModuleSystemTest);
107 }; 107 };
108 108
109 } // namespace extensions 109 } // namespace extensions
110 110
111 #endif // EXTENSIONS_RENDERER_MODULE_SYSTEM_TEST_H_ 111 #endif // EXTENSIONS_RENDERER_MODULE_SYSTEM_TEST_H_
OLDNEW
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | extensions/renderer/module_system_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698