Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1898223002: Removes most aura dependencies from WindowResizer (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, dcheng, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_aura_from_window_state
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes most aura dependencies from WindowResizer Last remaining one is for DockedWindowLayoutManager, which will be converted later. BUG=603369 TEST=covered by other tests R=jamescook@chromium.org Committed: https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92 Cr-Commit-Position: refs/heads/master@{#388414}

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 2

Patch Set 3 : nuke GetWorkAreaForWindowInParent and fix windows #

Patch Set 4 : nit and merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -303 lines) Patch
M ash/ash.gyp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/autoclick/autoclick_controller.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/display/screen_ash.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/display/screen_position_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/shared_display_edge_indicator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/window_tree_host_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/drag_drop/drag_drop_tracker.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 3 chunks +36 lines, -18 lines 0 comments Download
M ash/screen_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_view.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M ash/shell.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M ash/test/ui_controls_factory_ash.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/wm/aura/wm_globals_aura.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/aura/wm_globals_aura.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M ash/wm/aura/wm_root_window_controller_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/aura/wm_root_window_controller_aura.cc View 3 chunks +14 lines, -0 lines 0 comments Download
A + ash/wm/common/root_window_finder.h View 2 chunks +7 lines, -9 lines 0 comments Download
A + ash/wm/common/root_window_finder.cc View 2 chunks +11 lines, -13 lines 0 comments Download
M ash/wm/common/wm_globals.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/common/wm_root_window_controller.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
D ash/wm/coordinate_conversion.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ash/wm/coordinate_conversion.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M ash/wm/default_window_resizer.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M ash/wm/default_window_resizer.cc View 1 3 chunks +7 lines, -12 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer.cc View 8 chunks +15 lines, -17 lines 0 comments Download
M ash/wm/drag_window_resizer.cc View 9 chunks +18 lines, -18 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/panels/panel_window_resizer.cc View 1 2 3 8 chunks +14 lines, -13 lines 0 comments Download
M ash/wm/stacking_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/window_resizer.h View 1 3 chunks +15 lines, -4 lines 0 comments Download
M ash/wm/window_resizer.cc View 6 chunks +22 lines, -39 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/phantom_window_controller.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 19 chunks +47 lines, -47 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_ash.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
sky
4 years, 8 months ago (2016-04-19 17:08:54 UTC) #1
James Cook
LGTM with nit https://codereview.chromium.org/1898223002/diff/20001/ash/wm/common/wm_globals.h File ash/wm/common/wm_globals.h (right): https://codereview.chromium.org/1898223002/diff/20001/ash/wm/common/wm_globals.h#newcode50 ash/wm/common/wm_globals.h:50: virtual void LockCursor() = 0; nit: ...
4 years, 8 months ago (2016-04-19 20:13:38 UTC) #2
sky
https://codereview.chromium.org/1898223002/diff/20001/ash/wm/common/wm_globals.h File ash/wm/common/wm_globals.h (right): https://codereview.chromium.org/1898223002/diff/20001/ash/wm/common/wm_globals.h#newcode50 ash/wm/common/wm_globals.h:50: virtual void LockCursor() = 0; On 2016/04/19 20:13:38, James ...
4 years, 8 months ago (2016-04-20 02:01:41 UTC) #3
sky
4 years, 8 months ago (2016-04-20 02:01:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898223002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898223002/60001
4 years, 8 months ago (2016-04-20 02:02:06 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-20 02:58:21 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:20:24 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92
Cr-Commit-Position: refs/heads/master@{#388414}

Powered by Google App Engine
This is Rietveld 408576698