Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1700)

Unified Diff: ash/extended_desktop_unittest.cc

Issue 1898223002: Removes most aura dependencies from WindowResizer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_aura_from_window_state
Patch Set: nit and merge Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/drag_drop/drag_drop_tracker.cc ('k') | ash/screen_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/extended_desktop_unittest.cc
diff --git a/ash/extended_desktop_unittest.cc b/ash/extended_desktop_unittest.cc
index e625eda079f3fcaae1c23561a57ae49f321071e0..f1702cd0e67be3fa42cb4ed4d63383d97d9e0b92 100644
--- a/ash/extended_desktop_unittest.cc
+++ b/ash/extended_desktop_unittest.cc
@@ -9,7 +9,8 @@
#include "ash/shell_window_ids.h"
#include "ash/system/tray/system_tray.h"
#include "ash/test/ash_test_base.h"
-#include "ash/wm/coordinate_conversion.h"
+#include "ash/wm/aura/wm_window_aura.h"
+#include "ash/wm/common/root_window_finder.h"
#include "ash/wm/window_properties.h"
#include "ash/wm/window_util.h"
#include "base/strings/string_util.h"
@@ -314,17 +315,24 @@ TEST_F(ExtendedDesktopTest, GetRootWindowAt) {
SetSecondaryDisplayLayout(display::DisplayPlacement::LEFT);
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
- EXPECT_EQ(root_windows[1], wm::GetRootWindowAt(gfx::Point(-400, 100)));
- EXPECT_EQ(root_windows[1], wm::GetRootWindowAt(gfx::Point(-1, 100)));
- EXPECT_EQ(root_windows[0], wm::GetRootWindowAt(gfx::Point(0, 300)));
- EXPECT_EQ(root_windows[0], wm::GetRootWindowAt(gfx::Point(700, 300)));
+ EXPECT_EQ(root_windows[1], wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowAt(gfx::Point(-400, 100))));
+ EXPECT_EQ(root_windows[1], wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowAt(gfx::Point(-1, 100))));
+ EXPECT_EQ(root_windows[0], wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowAt(gfx::Point(0, 300))));
+ EXPECT_EQ(root_windows[0], wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowAt(gfx::Point(700, 300))));
// Zero origin.
- EXPECT_EQ(root_windows[0], wm::GetRootWindowAt(gfx::Point(0, 0)));
+ EXPECT_EQ(root_windows[0], wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowAt(gfx::Point(0, 0))));
// Out of range point should return the nearest root window
- EXPECT_EQ(root_windows[1], wm::GetRootWindowAt(gfx::Point(-600, 0)));
- EXPECT_EQ(root_windows[0], wm::GetRootWindowAt(gfx::Point(701, 100)));
+ EXPECT_EQ(root_windows[1], wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowAt(gfx::Point(-600, 0))));
+ EXPECT_EQ(root_windows[0], wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowAt(gfx::Point(701, 100))));
}
TEST_F(ExtendedDesktopTest, GetRootWindowMatching) {
@@ -338,33 +346,43 @@ TEST_F(ExtendedDesktopTest, GetRootWindowMatching) {
// Containing rect.
EXPECT_EQ(root_windows[1],
- wm::GetRootWindowMatching(gfx::Rect(-300, 10, 50, 50)));
+ wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowMatching(gfx::Rect(-300, 10, 50, 50))));
EXPECT_EQ(root_windows[0],
- wm::GetRootWindowMatching(gfx::Rect(100, 10, 50, 50)));
+ wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowMatching(gfx::Rect(100, 10, 50, 50))));
// Intersecting rect.
EXPECT_EQ(root_windows[1],
- wm::GetRootWindowMatching(gfx::Rect(-200, 0, 300, 300)));
+ wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowMatching(gfx::Rect(-200, 0, 300, 300))));
EXPECT_EQ(root_windows[0],
- wm::GetRootWindowMatching(gfx::Rect(-100, 0, 300, 300)));
+ wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowMatching(gfx::Rect(-100, 0, 300, 300))));
// Zero origin.
EXPECT_EQ(root_windows[0],
- wm::GetRootWindowMatching(gfx::Rect(0, 0, 0, 0)));
+ wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowMatching(gfx::Rect(0, 0, 0, 0))));
EXPECT_EQ(root_windows[0],
- wm::GetRootWindowMatching(gfx::Rect(0, 0, 1, 1)));
+ wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowMatching(gfx::Rect(0, 0, 1, 1))));
// Empty rect.
EXPECT_EQ(root_windows[1],
- wm::GetRootWindowMatching(gfx::Rect(-400, 100, 0, 0)));
+ wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowMatching(gfx::Rect(-400, 100, 0, 0))));
EXPECT_EQ(root_windows[0],
- wm::GetRootWindowMatching(gfx::Rect(100, 100, 0, 0)));
+ wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowMatching(gfx::Rect(100, 100, 0, 0))));
// Out of range rect should return the primary root window.
EXPECT_EQ(root_windows[0],
- wm::GetRootWindowMatching(gfx::Rect(-600, -300, 50, 50)));
+ wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowMatching(gfx::Rect(-600, -300, 50, 50))));
EXPECT_EQ(root_windows[0],
- wm::GetRootWindowMatching(gfx::Rect(0, 1000, 50, 50)));
+ wm::WmWindowAura::GetAuraWindow(
+ wm::GetRootWindowMatching(gfx::Rect(0, 1000, 50, 50))));
}
TEST_F(ExtendedDesktopTest, Capture) {
« no previous file with comments | « ash/drag_drop/drag_drop_tracker.cc ('k') | ash/screen_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698