Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 1901593004: Removes most aura dependencies from DockedWindowResizer (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@window_resizer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes most aura dependencies from DockedWindowResizer Remaining dependencies are necessitated by DockedWindowLayoutManager. BUG=603369 TEST=covered by other tests R=jamescook@chromium.org Committed: https://crrev.com/6bfa2cfa9b8f568db97602926871f48afabf16bf Cr-Commit-Position: refs/heads/master@{#388564}

Patch Set 1 #

Patch Set 2 : merge to trunk #

Patch Set 3 : merge #

Patch Set 4 : branch from master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -76 lines) Patch
M ash/wm/aura/wm_window_aura.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/aura/wm_window_aura.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ash/wm/common/wm_window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/dock/docked_window_resizer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/wm/dock/docked_window_resizer.cc View 11 chunks +55 lines, -72 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
sky
4 years, 8 months ago (2016-04-19 18:29:37 UTC) #1
James Cook
LGTM
4 years, 8 months ago (2016-04-19 20:25:06 UTC) #2
James Cook
nit: Should the CL title refer to DockedWindowSizer?
4 years, 8 months ago (2016-04-19 21:01:51 UTC) #3
sky
Updated subject.
4 years, 8 months ago (2016-04-20 02:05:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901593004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901593004/40001
4 years, 8 months ago (2016-04-20 19:03:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901593004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901593004/60001
4 years, 8 months ago (2016-04-20 19:04:11 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-20 20:09:03 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:25:58 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6bfa2cfa9b8f568db97602926871f48afabf16bf
Cr-Commit-Position: refs/heads/master@{#388564}

Powered by Google App Engine
This is Rietveld 408576698