Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView.

Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView.

This CL makes BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView
instead of BaseDateAndTimeInputType, and BaseDateAndTimeInputType::createView()
returns a BaseChooserOnlyDateAndTimeInputType instance if the multiple-fields
flag is off.

- Now BaseChooserOnlyDateAndTimeInputType is built on non-Android platforms.

- if !ENABLE(INPUT_MULTIPLE_FIELDS_UI), each of temporal input types doesn't
  inherit from BaseChooserOnlyDateAndTimeInputType, which is not an InputType.

This CL has no behavior change.

BUG=243714
Committed: https://crrev.com/bf84c6b983f056ca8df920c897642f84e47d23f4
Cr-Commit-Position: refs/heads/master@{#388202}

[tkent, 2016-04-19 08:23:17]

Description was changed from

==========
Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView.

This CL makes BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView
instead of BaseDateAndTimeInputType, and BaseDateAndTimeInputType::createView()
return a BaseChooserOnlyDateAndTimeInputType instance if the multiple-fields
flag is off.

This CL has no behavior change.

BUG=243714
==========

to

==========
Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView.

This CL makes BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView
instead of BaseDateAndTimeInputType, and BaseDateAndTimeInputType::createView()
return a BaseChooserOnlyDateAndTimeInputType instance if the multiple-fields
flag is off.

- if !ENABLE(INPUT_MULTIPLE_FIELDS_UI), each of temporal input types doesn't
  inherit from BaseChooserOnlyDateAndTimeInputType, which is not an InputType.

This CL has no behavior change.

BUG=243714
==========

[tkent, 2016-04-19 08:26:06]

Description was changed from

==========
Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView.

This CL makes BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView
instead of BaseDateAndTimeInputType, and BaseDateAndTimeInputType::createView()
return a BaseChooserOnlyDateAndTimeInputType instance if the multiple-fields
flag is off.

- if !ENABLE(INPUT_MULTIPLE_FIELDS_UI), each of temporal input types doesn't
  inherit from BaseChooserOnlyDateAndTimeInputType, which is not an InputType.

This CL has no behavior change.

BUG=243714
==========

to

==========
Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView.

This CL makes BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView
instead of BaseDateAndTimeInputType, and BaseDateAndTimeInputType::createView()
return a BaseChooserOnlyDateAndTimeInputType instance if the multiple-fields
flag is off.

- Now BaseChooserOnlyDateAndTimeInputType is built on non-Android platforms.

- if !ENABLE(INPUT_MULTIPLE_FIELDS_UI), each of temporal input types doesn't
  inherit from BaseChooserOnlyDateAndTimeInputType, which is not an InputType.

This CL has no behavior change.

BUG=243714
==========

[tkent, 2016-04-19 08:29:46]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2016-04-19 08:29:47]

Keishi, would you review this please?
No hurry.

https://codereview.chromium.org/1896073002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h
(right):

https://codereview.chromium.org/1896073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h:37:
// TODO(tkent): Rename this to ChooserOnlyDateAndTimeInputTypeView.
or, rename all of "DateAndTime" to "Temporal".  WDYT?

[tkent, 2016-04-19 12:30:32]

https://codereview.chromium.org/1896073002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h
(right):

https://codereview.chromium.org/1896073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h:37:
// TODO(tkent): Rename this to ChooserOnlyDateAndTimeInputTypeView.
On 2016/04/19 at 08:29:47, tkent wrote:
> or, rename all of "DateAndTime" to "Temporal".  WDYT?

I meant renaming this to ChooserOnlyDateAndTimeInputTypeView, or this to
ChooserOnlyTemporalInputTypeView AND other FooDateAndTimeBar to FooTemoralBar.

[keishi, 2016-04-19 13:05:03]

LGTM

https://codereview.chromium.org/1896073002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h
(right):

https://codereview.chromium.org/1896073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h:37:
// TODO(tkent): Rename this to ChooserOnlyDateAndTimeInputTypeView.
On 2016/04/19 12:30:32, tkent wrote:
> On 2016/04/19 at 08:29:47, tkent wrote:
> > or, rename all of "DateAndTime" to "Temporal".  WDYT?
> 
> I meant renaming this to ChooserOnlyDateAndTimeInputTypeView, or this to
> ChooserOnlyTemporalInputTypeView AND other FooDateAndTimeBar to FooTemoralBar.

These are input fields that accept some temporal expressions so I think that
makes sense.

[tkent, 2016-04-19 14:05:24]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-04-19 14:05:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1896073002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1896073002/1

[tkent, 2016-04-19 14:07:12]

Description was changed from

==========
Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView.

This CL makes BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView
instead of BaseDateAndTimeInputType, and BaseDateAndTimeInputType::createView()
return a BaseChooserOnlyDateAndTimeInputType instance if the multiple-fields
flag is off.

- Now BaseChooserOnlyDateAndTimeInputType is built on non-Android platforms.

- if !ENABLE(INPUT_MULTIPLE_FIELDS_UI), each of temporal input types doesn't
  inherit from BaseChooserOnlyDateAndTimeInputType, which is not an InputType.

This CL has no behavior change.

BUG=243714
==========

to

==========
Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView.

This CL makes BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView
instead of BaseDateAndTimeInputType, and BaseDateAndTimeInputType::createView()
returns a BaseChooserOnlyDateAndTimeInputType instance if the multiple-fields
flag is off.

- Now BaseChooserOnlyDateAndTimeInputType is built on non-Android platforms.

- if !ENABLE(INPUT_MULTIPLE_FIELDS_UI), each of temporal input types doesn't
  inherit from BaseChooserOnlyDateAndTimeInputType, which is not an InputType.

This CL has no behavior change.

BUG=243714
==========

[commit-bot: I haz the power, 2016-04-19 14:09:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:12:06]

Description was changed from

==========
Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView.

This CL makes BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView
instead of BaseDateAndTimeInputType, and BaseDateAndTimeInputType::createView()
returns a BaseChooserOnlyDateAndTimeInputType instance if the multiple-fields
flag is off.

- Now BaseChooserOnlyDateAndTimeInputType is built on non-Android platforms.

- if !ENABLE(INPUT_MULTIPLE_FIELDS_UI), each of temporal input types doesn't
  inherit from BaseChooserOnlyDateAndTimeInputType, which is not an InputType.

This CL has no behavior change.

BUG=243714
==========

to

==========
Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView.

This CL makes BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView
instead of BaseDateAndTimeInputType, and BaseDateAndTimeInputType::createView()
returns a BaseChooserOnlyDateAndTimeInputType instance if the multiple-fields
flag is off.

- Now BaseChooserOnlyDateAndTimeInputType is built on non-Android platforms.

- if !ENABLE(INPUT_MULTIPLE_FIELDS_UI), each of temporal input types doesn't
  inherit from BaseChooserOnlyDateAndTimeInputType, which is not an InputType.

This CL has no behavior change.

BUG=243714

Committed: https://crrev.com/bf84c6b983f056ca8df920c897642f84e47d23f4
Cr-Commit-Position: refs/heads/master@{#388202}
==========

[commit-bot: I haz the power, 2016-04-22 19:12:07]

Patchset 1 (id:??) landed as
https://crrev.com/bf84c6b983f056ca8df920c897642f84e47d23f4
Cr-Commit-Position: refs/heads/master@{#388202}