third_party/WebKit/Source/core/html/forms/BaseDateAndTimeInputType.cpp - Issue 1896073002: Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/BaseDateAndTimeInputType.cpp

Issue 1896073002: Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h ('K') | « third_party/WebKit/Source/core/html/forms/BaseDateAndTimeInputType.h ('k') | third_party/WebKit/Source/core/html/forms/DateInputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/BaseDateAndTimeInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/BaseDateAndTimeInputType.cpp b/third_party/WebKit/Source/core/html/forms/BaseDateAndTimeInputType.cpp

index 7461c29b24e89a859ec590914bccb1f2185fba41..136f2de1293bc28e40ee1f8e0ff362186b563aeb 100644

--- a/third_party/WebKit/Source/core/html/forms/BaseDateAndTimeInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/BaseDateAndTimeInputType.cpp

@@ -31,6 +31,7 @@

#include "core/html/forms/BaseDateAndTimeInputType.h"

#include "core/html/HTMLInputElement.h"

+#include "core/html/forms/BaseChooserOnlyDateAndTimeInputType.h"

#include "platform/text/PlatformLocale.h"

#include "wtf/CurrentTime.h"

#include "wtf/DateMath.h"

@@ -48,9 +49,9 @@ static const int msecPerSecond = 1000;

InputTypeView* BaseDateAndTimeInputType::createView()

{

- // TODO(tkent): Returns ChooserOnlyDateAndTimeInputTypeView or

- // MultipleFieldsDateAndTimeInputTypeView, depending on

- // RuntimeEnabledFeatures::inputMultipleFieldsUIEnabled().

+ if (!RuntimeEnabledFeatures::inputMultipleFieldsUIEnabled())

+ return BaseChooserOnlyDateAndTimeInputType::create(element(), *this);

+ // TODO(tkent): Returns MultipleFieldsDateAndTimeInputTypeView.

// crbug.com/243714

return this;

}