Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h

Issue 1896073002: Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h
diff --git a/third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h b/third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h
index 7a6ddc03abae61c54001906a46b6fdf599c63e6b..cffe452395903a7b7c4f3525af3eac4c6bd7b6a5 100644
--- a/third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h
+++ b/third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h
@@ -26,9 +26,6 @@
#ifndef BaseChooserOnlyDateAndTimeInputType_h
#define BaseChooserOnlyDateAndTimeInputType_h
-#include "wtf/build_config.h"
-
-#if !ENABLE(INPUT_MULTIPLE_FIELDS_UI)
#include "core/html/forms/BaseClickableWithKeyInputType.h"
#include "core/html/forms/BaseDateAndTimeInputType.h"
#include "core/html/forms/DateTimeChooser.h"
@@ -37,16 +34,17 @@
namespace blink {
-class BaseChooserOnlyDateAndTimeInputType : public BaseDateAndTimeInputType, public DateTimeChooserClient {
+// TODO(tkent): Rename this to ChooserOnlyDateAndTimeInputTypeView.
tkent 2016/04/19 08:29:47 or, rename all of "DateAndTime" to "Temporal". WD
tkent 2016/04/19 12:30:32 I meant renaming this to ChooserOnlyDateAndTimeInp
keishi 2016/04/19 13:05:02 These are input fields that accept some temporal e
+class BaseChooserOnlyDateAndTimeInputType final : public InputTypeView, public DateTimeChooserClient {
USING_GARBAGE_COLLECTED_MIXIN(BaseChooserOnlyDateAndTimeInputType);
USING_PRE_FINALIZER(BaseChooserOnlyDateAndTimeInputType, closeDateTimeChooser);
-protected:
- BaseChooserOnlyDateAndTimeInputType(HTMLInputElement&);
+public:
+ static BaseChooserOnlyDateAndTimeInputType* create(HTMLInputElement&, BaseDateAndTimeInputType&);
~BaseChooserOnlyDateAndTimeInputType() override;
-
DECLARE_VIRTUAL_TRACE();
private:
+ BaseChooserOnlyDateAndTimeInputType(HTMLInputElement&, BaseDateAndTimeInputType&);
void closeDateTimeChooser();
// InputTypeView functions:
@@ -66,10 +64,10 @@ private:
void didChooseValue(double) override;
void didEndChooser() override;
+ Member<BaseDateAndTimeInputType> m_inputType;
Member<DateTimeChooser> m_dateTimeChooser;
};
} // namespace blink
-#endif // ENABLE(INPUT_MULTIPLE_FIELDS_UI)
#endif // BaseChooserOnlyDateAndTimeInputType_h
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698