third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.cpp - Issue 1896073002: Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.cpp

Issue 1896073002: Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h ('K') | « third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.h ('k') | third_party/WebKit/Source/core/html/forms/BaseDateAndTimeInputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.cpp b/third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.cpp

index dd26b17450f36e5c066ff5bf8dc9d53a6ef11218..207e44193204239034974365f47a5bc1a6702f77 100644

--- a/third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.cpp

@@ -62,13 +62,13 @@ void BaseClickableWithKeyInputType::handleKeypressEvent(HTMLInputElement& elemen

}

-void BaseClickableWithKeyInputType::handleKeyupEvent(InputType& inputType, KeyboardEvent* event)

+void BaseClickableWithKeyInputType::handleKeyupEvent(InputTypeView& inputTypeView, KeyboardEvent* event)

{

const String& key = event->keyIdentifier();

if (key != "U+0020")

return;

// Simulate mouse click for spacebar for button types.

- inputType.dispatchSimulatedClickIfActive(event);

+ inputTypeView.dispatchSimulatedClickIfActive(event);

}

// FIXME: Could share this with BaseCheckableInputType and RangeInputType if we had a common base class.