third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.h - Issue 1896073002: Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.h

Issue 1896073002: Make BaseChooserOnlyDateAndTimeInputType a subclass of InputTypeView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h ('K') | « third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp ('k') | third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.h

diff --git a/third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.h b/third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.h

index cf5ad4f1cb6a5d408170b766e449fa02cbcec37f..5fd31a9bf7525c1cf435f6c68836b0e2dc1d88d3 100644

--- a/third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.h

+++ b/third_party/WebKit/Source/core/html/forms/BaseClickableWithKeyInputType.h

@@ -41,7 +41,7 @@ class CORE_EXPORT BaseClickableWithKeyInputType : public InputType {

public:

static void handleKeydownEvent(HTMLInputElement&, KeyboardEvent*);

static void handleKeypressEvent(HTMLInputElement&, KeyboardEvent*);

- static void handleKeyupEvent(InputType&, KeyboardEvent*);

+ static void handleKeyupEvent(InputTypeView&, KeyboardEvent*);

static void accessKeyAction(HTMLInputElement&, bool sendMouseEvents);

protected: